Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations languages #883

Merged
merged 5 commits into from
Oct 13, 2024
Merged

Conversation

mtsfer
Copy link
Contributor

@mtsfer mtsfer commented Oct 5, 2024

Reference: #868

Also fixes korean language code. The correct one is "ko".

Closes: #854

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 5, 2024
@dr5hn
Copy link
Owner

dr5hn commented Oct 7, 2024

@mtsfer i think it should be

zh-cn and ko-kr respectively.

zh is the parent language code and cn is sub language code.

@mtsfer
Copy link
Contributor Author

mtsfer commented Oct 7, 2024

@dr5hn I've found this discussion about Chinese variations, and zh-CN is indeed the better option.

However, I wasn't able to find any reliable resource about ko-KR. Based on here, ko is the standard Korean, ko-KP is the North Korea variation and ko-KR is the South Korea variation.

Defaulting to ko while not sure which variation is being used on Korean translations wouldn't be a safer move here?

@dr5hn
Copy link
Owner

dr5hn commented Oct 8, 2024

@mtsfer Agree with keeping ko as is and changing zh to zh-cn. Please make required changes and rebase the branch.

Thanks so much for your active participation and all the work you're doing.

@dr5hn
Copy link
Owner

dr5hn commented Oct 11, 2024

@mtsfer Could you please rebase you branch and resolve conflicts?

@mtsfer
Copy link
Contributor Author

mtsfer commented Oct 11, 2024

@dr5hn Sorry for the late reply. I'm working on this right now.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 13, 2024
@dr5hn dr5hn merged commit 17d3b5d into dr5hn:master Oct 13, 2024
@mtsfer mtsfer deleted the fix-translations-languages branch October 13, 2024 13:12
@adevade
Copy link
Contributor

adevade commented Jan 29, 2025

@dr5hn @mtsfer This PR broke the currency_symbol for a couple of countries using kr. It now says ko instead of kr as it should be, and was before.

  • Sweden (ID 213)
  • Iceland (ID 100)
  • Norway (ID 165)
  • Bouvet Island (ID 30)
  • Svalbard and Jan Mayen Islands (ID 211)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations of subregions using language name instead of code
3 participants