Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subregions languages and chinese iso code #868

Closed
wants to merge 1 commit into from
Closed

Fix subregions languages and chinese iso code #868

wants to merge 1 commit into from

Conversation

mtsfer
Copy link
Contributor

@mtsfer mtsfer commented Oct 1, 2024 •
edited
Loading

  • Some languages on the subregions dataset were using the language name instead of the language ISO code, going against the pattern adopted in the rest of the datasets.
  • Chinese ISO code was wrongly referenced as cn. The correct code is zn.

Closes #854

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Oct 1, 2024
@dr5hn
Copy link
Owner

dr5hn commented Oct 5, 2024

@mtsfer Thanks for the PR!

Could you please rebase the PR first? THanks

@mtsfer mtsfer closed this by deleting the head repository Oct 5, 2024
@mtsfer mtsfer mentioned this pull request Oct 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translations of subregions using language name instead of code
2 participants
@mtsfer @dr5hn