Fix DragDropTests #8860
Closed
Fix DragDropTests #8860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sharwell
commented
Mar 15, 2023
•
sharwell
commented
- Make sure to start a drag/drop operation on DragEnter (DragOver may or may not occur due to test speed)
- Match Mouse Down with Mouse Up
- Remove artificial delays
* Make sure to start a drag/drop operation on DragEnter * Match Mouse Down with Mouse Up * Remove artificial delays
ghost
assigned 
This was referenced Mar 16, 2023
Flaky test: dragenter_set_dropimagetype_message_messagereplacementtoken_returnsexptected_async
#8746
Open
dreddy-work
reviewed
Mar 16, 2023
| @@ -120,7 +120,7 @@ public async Task Button_AchorNone_NoResizeOnWindowSizeWiderAsync() | |||
| form, | |||
| inputSimulator => inputSimulator.Mouse | |||
| .LeftButtonDown() | |||
| .MoveMouseBy(form.DisplayRectangle.Width, 0) | |||
| .DragMouseBy(form.DisplayRectangle.Width, 0) | |||
There was a problem hiding this comment.
I was able to get this working with MoveMouseTo but send virtual coordinates here.
dreddy-work
reviewed
Mar 16, 2023
| @@ -266,7 +263,7 @@ public async Task Button_Mouse_Press_With_Drag_Off_Button_Does_Not_Cause_Button_ | |||
| form, | |||
| inputSimulator => inputSimulator.Mouse | |||
| .LeftButtonDown() | |||
| .MoveMouseTo(virtualPoint.X, virtualPoint.Y) | |||
There was a problem hiding this comment.
Did you see MoveMouseTo was also problematic?
sharwell
force-pushed
the
fix-tests
branch
2 times, most recently
from
fa43888 to
fa9edb3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.