Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable skipped test: Button_AchorNone_NoResizeOnWindowSizeTallerAsync #6714

Closed
Tracked by #6690 ...
vladimir-krestov opened this issue Feb 18, 2022 · 1 comment · Fixed by #8950
Closed
Tracked by #6690 ...

Re-enable skipped test: Button_AchorNone_NoResizeOnWindowSizeTallerAsync #6714

vladimir-krestov opened this issue Feb 18, 2022 · 1 comment · Fixed by #8950
Labels
test-bug Problem in test source code (most likely)

Comments

@vladimir-krestov
Copy link
Contributor

vladimir-krestov commented Feb 18, 2022

Problem description:

  • Button_AchorNone_NoResizeOnWindowSizeTallerAsync unit test fails sometime in x86 Release CI build for successful PRs, that blocking deployment of fixes into sdk.

Stack trace (System.Windows.Forms.UI.IntegrationTests_net7.0_x86.log):

System.Windows.Forms.UITests.ButtonTests.Button_AchorNone_NoResizeOnWindowSizeTallerAsync [FAIL]
      Assert.True() Failure
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ButtonTests.cs(151,0): at System.Windows.Forms.UITests.ButtonTests.<Button_AchorNone_NoResizeOnWindowSizeTallerAsync>b__6_0(Form form, Button button)
        /_/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/Infra/ControlTestBase.cs(244,0): at System.Windows.Forms.UITests.ControlTestBase.<>c__DisplayClass27_0`1.<<RunFormAsync>b__0>d.MoveNext()
        --- End of stack trace from previous location ---
           at Microsoft.VisualStudio.Threading.JoinableTask.JoinAsync(CancellationToken cancellationToken)
        /_/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/Infra/ControlTestBase.cs(255,0): at System.Windows.Forms.UITests.ControlTestBase.RunFormAsync[T](Func`1 createDialog, Func`3 testDriverAsync)
        /_/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/Infra/ControlTestBase.cs(173,0): at System.Windows.Forms.UITests.ControlTestBase.RunSingleControlTestAsync[T](Func`3 testDriverAsync, Func`1 createControl, Func`1 createForm)
        /_/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ButtonTests.cs(394,0): at System.Windows.Forms.UITests.ButtonTests.RunTestAsync(Func`3 runTest)
        /_/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ButtonTests.cs(136,0): at System.Windows.Forms.UITests.ButtonTests.Button_AchorNone_NoResizeOnWindowSizeTallerAsync()
        --- End of stack trace from previous location ---
      Output:
        Moving mouse to (276, 318).
        Screen resolution of (1024, 768) translates mouse to (17664, 27136).

Expected behavior:

  • All correct tests pass every time.

Minimal repro:

  • Run unit tests on x86 environment (or create a PR with changes, CI build will do it)
@vladimir-krestov vladimir-krestov added the test-bug Problem in test source code (most likely) label Feb 18, 2022
@dmitrii-drobotov
Copy link
Contributor

Also failing on x64 and arm64
image
image

dmitrii-drobotov pushed a commit to dmitrii-drobotov/winforms that referenced this issue Apr 8, 2022
These tests sometimes fail in CI and block deployment.
Related issues: dotnet#6610, dotnet#6714, dotnet#6739, dotnet#6926
dmitrii-drobotov pushed a commit to dmitrii-drobotov/winforms that referenced this issue Apr 8, 2022
These tests sometimes fail in CI and block deployment.
Related issues: dotnet#6610, dotnet#6714, dotnet#6739, dotnet#6926
dmitrii-drobotov pushed a commit to dmitrii-drobotov/winforms that referenced this issue Apr 8, 2022
These tests sometimes fail in CI and block deployment.
Related issues: dotnet#6610, dotnet#6714, dotnet#6739, dotnet#6926
dreddy-work pushed a commit that referenced this issue Apr 8, 2022
These tests sometimes fail in CI and block deployment.
Related issues: #6610, #6714, #6739, #6926
@Tanya-Solyanik Tanya-Solyanik changed the title Button_AchorNone_NoResizeOnWindowSizeTallerAsync test is flaky in x86 Release Re-enable skipped test: Button_AchorNone_NoResizeOnWindowSizeTallerAsync Jul 15, 2022
@ghost ghost added the 🚧 work in progress Work that is current in progress label Mar 14, 2023
sharwell added a commit to sharwell/winforms that referenced this issue Mar 16, 2023
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Mar 16, 2023
sharwell added a commit to sharwell/winforms that referenced this issue Apr 6, 2023
* Wait for WM_MOUSEMOVE processing before sending more messages.
* Match WM_LBUTTONDOWN with WM_LBUTTONUP

Closes dotnet#6609
Closes dotnet#6714
Closes dotnet#7297
Closes dotnet#7407
Closes dotnet#8635
@ghost ghost added the 🚧 work in progress Work that is current in progress label Apr 6, 2023
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Apr 6, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-bug Problem in test source code (most likely)
Projects
None yet
2 participants