Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added omnisharp.enableMsBuildLoadProjectsOnDemand #2750

Merged
merged 2 commits into from
Dec 18, 2018

Conversation

dmgonch
Copy link
Contributor

@dmgonch dmgonch commented Dec 17, 2018

The new setting is to allow enabling feature OmniSharp/omnisharp-roslyn#1316
PR: OmniSharp/omnisharp-roslyn#1322

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #2750 into master will decrease coverage by 0.19%.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2750     +/-   ##
========================================
- Coverage    65.1%   64.9%   -0.2%     
========================================
  Files         101     101             
  Lines        4396    4400      +4     
  Branches      635     634      -1     
========================================
- Hits         2862    2856      -6     
- Misses       1351    1356      +5     
- Partials      183     188      +5
Flag Coverage Δ
#integration 53.03% <50%> (-0.19%) ⬇️
#unit 85.12% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
src/observers/OptionChangeObserver.ts 100% <ø> (ø) ⬆️
src/omnisharp/server.ts 69.83% <0%> (-0.14%) ⬇️
src/omnisharp/options.ts 100% <100%> (ø) ⬆️
src/omnisharp/delayTracker.ts 68.42% <0%> (-5.27%) ⬇️
src/omnisharp/requestQueue.ts 75.75% <0%> (-4.55%) ⬇️
src/features/diagnosticsProvider.ts 77.92% <0%> (-2.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80bf9ae...fda1556. Read the comment docs.

Copy link

@rchande rchande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo copyediting

package.json Outdated Show resolved Hide resolved
@rchande
Copy link

rchande commented Dec 17, 2018

@akshita31 Care to sign off here?

@rchande rchande merged commit bf6f4f8 into dotnet:master Dec 18, 2018
@rchande
Copy link

rchande commented Dec 18, 2018

@dmgonch I created the release https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.18.0-beta3 that you can install (in addition to enabled using latest omnisharp) to try this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants