Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On demand projects loading when working with big C# codebases #1322

Merged
merged 13 commits into from
Dec 18, 2018
Merged

On demand projects loading when working with big C# codebases #1322

merged 13 commits into from
Dec 18, 2018

Conversation

dmgonch
Copy link
Contributor

@dmgonch dmgonch commented Oct 28, 2018 •
edited
Loading

Implements feature #1316.

@dmgonch dmgonch force-pushed the feature/OnDemandMsBuildProjectsLoad branch from 16676ee to 2c26ee9 Compare October 29, 2018 03:39
@dmgonch dmgonch closed this Nov 3, 2018
@dmgonch dmgonch reopened this Nov 3, 2018
@dmgonch
Copy link
Contributor Author

dmgonch commented Dec 17, 2018

@rchande I believe I addressed all outstanding feedback but please let me know if I missed anything. Thanks!

dmgonch added a commit to dmgonch/omnisharp-vscode that referenced this pull request Dec 17, 2018
@dmgonch
Added omnisharp.enableMsBuildLoadProjectsOnDemand to allow enabling f…
67b4173 
…eature OmniSharp/omnisharp-roslyn#1322
@dmgonch dmgonch mentioned this pull request Dec 17, 2018
Merged
rchande
rchande approved these changes Dec 17, 2018
View reviewed changes
Copy link

@rchande rchande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@rchande rchande merged commit af7dde5 into OmniSharp:master Dec 18, 2018
@dmgonch dmgonch deleted the feature/OnDemandMsBuildProjectsLoad branch December 23, 2018 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchande rchande rchande approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmgonch @rchande @filipw