Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure zroSimd12Elm3 is explicitly nulled out #85625

Merged
merged 1 commit into from
May 2, 2023
Merged

Ensure zroSimd12Elm3 is explicitly nulled out #85625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/coreclr/jit/codegencommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ CodeGen::CodeGen(Compiler* theCompiler) : CodeGenInterface(theCompiler)
negBitmaskDbl = nullptr;
absBitmaskFlt = nullptr;
absBitmaskDbl = nullptr;
zroSimd12Elm3 = nullptr;
u8ToDblBitmask = nullptr;
#endif // defined(TARGET_XARCH)

Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/jit/simdcodegenxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ void CodeGen::genSimd12UpperClear(regNumber tgtReg)
zroSimd12Elm3 = GetEmitter()->emitSimd16Const(constValue);
}

GetEmitter()->emitIns_SIMD_R_R_C(INS_andpd, EA_16BYTE, tgtReg, tgtReg, zroSimd12Elm3, 0);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

andpd vs andps doesn't matter, but it should've been andps since that's "more correct" for TYP_SIMD12 (e.g. Vector3 where all fields are float).

GetEmitter()->emitIns_SIMD_R_R_C(INS_andps, EA_16BYTE, tgtReg, tgtReg, zroSimd12Elm3, 0);
}
}

Expand Down