Ensure zroSimd12Elm3 is explicitly nulled out #85625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsNot doing this meant you could get non-determinstic bits in some scenarios, leading to sporadic failure
|
tannergooding
commented
May 2, 2023
| @@ -548,7 +548,7 @@ void CodeGen::genSimd12UpperClear(regNumber tgtReg) | |||
| zroSimd12Elm3 = GetEmitter()->emitSimd16Const(constValue); | |||
| } | |||
|
|
|||
| GetEmitter()->emitIns_SIMD_R_R_C(INS_andpd, EA_16BYTE, tgtReg, tgtReg, zroSimd12Elm3, 0); | |||
There was a problem hiding this comment.
andpd vs andps doesn't matter, but it should've been andps since that's "more correct" for TYP_SIMD12 (e.g. Vector3 where all fields are float).
jakobbotsch
approved these changes
May 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not doing this meant you could get non-determinstic bits in some scenarios, leading to sporadic failure