Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idIsBound() check in emitDispJumpList() #71086

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

kunalspathak
Copy link
Member

For jumps that are injected in the prolog of initialization need to be handled inside emitDispJumpList().

Fixes: #71049

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 21, 2022
@ghost ghost assigned kunalspathak Jun 21, 2022
@ghost
Copy link

ghost commented Jun 21, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

For jumps that are injected in the prolog of initialization need to be handled inside emitDispJumpList().

Fixes: #71049

Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for now.

We should probably add a helper to commonize/print jmp instrDescs. E.g., you could also print Bound ones, like the disasm code:

            if (id->idIsBound())
            {
                emitPrintLabel(id->idAddr()->iiaIGlabel);
            }
            else
            {
                printf("L_M%03u_" FMT_BB, emitComp->compMethodID, id->idAddr()->iiaBBlabel->bbNum);
            }

@kunalspathak
Copy link
Member Author

We should probably add a helper to commonize/print jmp instrDescs. E.g., you could also print Bound ones, like the disasm code:

This needs modification as part of #70389. Will do it at that time.

@kunalspathak kunalspathak merged commit ead19a3 into dotnet:main Jun 22, 2022
@kunalspathak kunalspathak deleted the jmplist branch June 22, 2022 04:36
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AVs in emitDispJumpList
2 participants