Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVs in emitDispJumpList #71049

Closed
jakobbotsch opened this issue Jun 21, 2022 · 5 comments · Fixed by #71086
Closed

AVs in emitDispJumpList #71049

jakobbotsch opened this issue Jun 21, 2022 · 5 comments · Fixed by #71086
Assignees
@kunalspathak
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
7.0.0

Comments

@jakobbotsch
Copy link
Member

I am frequently hitting access violations inside emitDispJumpList on x64 when jit dump is enabled.
Easy way to repro it is to set COMPlus_JitStdOutFile=foo.txt and COMPlus_JitDump=* and run superpmi.
For the one example case I looked at iiaBBLabel is not a valid pointer and the instrDescJmp* we are processing is the jne in the following code:

IN0671:        vmovdqu  xmmword ptr [ebp+eax-0CH], xmm4
IN0672:        vmovdqu  xmmword ptr [ebp+eax+04H], xmm4
IN0673:        vmovdqu  xmmword ptr [ebp+eax+14H], xmm4
IN0674:        add      eax, 48
IN0675:        jne      SHORT  -5 instr
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 21, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 21, 2022
@ghost
Copy link

ghost commented Jun 21, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

I am frequently hitting access violations inside emitDispJumpList on x64 when jit dump is enabled.
Easy way to repro it is to set COMPlus_JitStdOutFile=foo.txt and COMPlus_JitDump=* and run superpmi.
For the one example case I looked at iiaBBLabel is not a valid pointer and the instrDescJmp* we are processing is the jne in the following code:

IN0671:        vmovdqu  xmmword ptr [ebp+eax-0CH], xmm4
IN0672:        vmovdqu  xmmword ptr [ebp+eax+04H], xmm4
IN0673:        vmovdqu  xmmword ptr [ebp+eax+14H], xmm4
IN0674:        add      eax, 48
IN0675:        jne      SHORT  -5 instr
Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch
Copy link
Member Author

cc @kunalspathak

@kunalspathak
Copy link
Member

Thanks @jakobbotsch . I will take a look.

@AndyAyersMS
Copy link
Member

I'm hitting this too, on windows arm64.

@kunalspathak
Copy link
Member

Yep, will send out PR soon.

@kunalspathak kunalspathak mentioned this issue Jun 21, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 21, 2022
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Jun 21, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Jun 21, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 22, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Add idIsBound() check in emitDispJumpList() kunalspathak/runtime
4 participants
@jakobbotsch @AndyAyersMS @kunalspathak @JulieLeeMSFT