Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more validation to quic config #56923

Merged
merged 1 commit into from
Aug 10, 2021
Merged

add more validation to quic config #56923

merged 1 commit into from
Aug 10, 2021

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Aug 5, 2021

update client config validation. This is essentially #55877 without the LocalCertificateSelectionCallback check.
It seems like HttpClient would always set it and there is no easy way to get around it AFAIK.

The server part sneaked back in (unintentionally) in #55468 as part of merge resolve.

fixes #55759

@wfurt wfurt requested a review from a team August 5, 2021 18:22
@wfurt wfurt self-assigned this Aug 5, 2021
@ghost
Copy link

ghost commented Aug 5, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

update client config validation. This is essentially #55877 without the LocalCertificateSelectionCallback check.
It seems like HttpClient would always set it and there is no easy way to get around it AFAIK.

The server part sneaked back in (unintentionally) in #55468 as part of merge resolve.

fixes #55759

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Quic

Milestone: -

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@wfurt
Copy link
Member Author

wfurt commented Aug 10, 2021

test failures unrelated.

@wfurt wfurt merged commit 08166d3 into dotnet:main Aug 10, 2021
@wfurt wfurt deleted the options branch August 10, 2021 04:38
@karelz karelz added this to the 6.0.0 milestone Aug 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUIC] Throw PNSE for unsupported SslOptions (client and server)
3 participants