-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
throw PNSE for unsupported SSL options in Quic. #55877
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue Detailsthrow for few options we do not support to make it obvious fixes #55759
|
PNSP -> PNSE? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where would the check be for #55468?
You've added the validation into |
ok, that make sense. I will update #55468 as well since I'm going to probably touch it anyway. We may split pre-validation to separate method but I'm not sure I want to do that right now. ConfigurationOpenDelegate may still fail so we should figure out how to better surface exceptions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. Looking forward for the SNI PR solution.
...Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Interop/SafeMsQuicConfigurationHandle.cs
Outdated
Show resolved
Hide resolved
failing test fixed by #56047. |
throw for few options we do not support to make it obvious
fixes #55759