Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable System.Diagnostics.Tests.EventLogSourceCreationTests #36138

Merged
merged 3 commits into from
May 13, 2020
Merged

Disable System.Diagnostics.Tests.EventLogSourceCreationTests #36138

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae908da
Disable System.Diagnostics.Tests.EventLogSourceCreationTests.CheckSou…
safern May 8, 2020
cb5eb35
Fix trait to skip tests in CI
safern May 8, 2020
d6a5f17
Use ActiveIssue instead
safern May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogSourceCreationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace System.Diagnostics.Tests
{
public class EventLogSourceCreationTests
{
[Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
[ActiveIssue("https://github.com/dotnet/runtime/issues/36135")]
[ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
public void CheckSourceExistenceAndDeletion()
{
Expand All @@ -29,7 +29,7 @@ public void CheckSourceExistenceAndDeletion()
Assert.False(EventLog.SourceExists(source));
}

[Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
[ActiveIssue("https://github.com/dotnet/runtime/issues/36135")]
[ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
public void LogNameWithSame8FirstChars_NetCore()
Expand All @@ -56,7 +56,7 @@ public void LogNameWithSame8FirstChars_NetCore()
}
}

[Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
[ActiveIssue("https://github.com/dotnet/runtime/issues/36135")]
[ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
[SkipOnTargetFramework(~TargetFrameworkMonikers.NetFramework)]
public void LogNameWithSame8FirstChars_NetFramework()
Expand Down Expand Up @@ -145,7 +145,7 @@ public void SourceDataNull()
Assert.Throws<ArgumentNullException>(() => EventLog.CreateEventSource(null));
}

[Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
[ActiveIssue("https://github.com/dotnet/runtime/issues/36135")]
[ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
public void SourceAlreadyExistsWhenCreatingSource()
{
Expand Down