Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable System.Diagnostics.Tests.EventLogSourceCreationTests #36138

Merged
merged 3 commits into from
May 13, 2020
Merged

Disable System.Diagnostics.Tests.EventLogSourceCreationTests #36138

merged 3 commits into from
May 13, 2020

Conversation

safern
Copy link
Member

@safern safern commented May 8, 2020 •
edited
Loading

Related to: #36135

cc: @dotnet/runtime-infrastructure @Anipik

@ghost
Copy link

ghost commented May 8, 2020

Tagging subscribers to this area: @tommcdon, @krwq
Notify danmosemsft if you want to be subscribed.

@stephentoub stephentoub mentioned this pull request May 8, 2020
Open
@safern safern closed this May 8, 2020
@safern safern deleted the DisableEventLogTest branch May 8, 2020 22:12
@jaredpar jaredpar mentioned this pull request May 11, 2020
Closed
@safern safern restored the DisableEventLogTest branch May 13, 2020 02:07
@safern safern reopened this May 13, 2020
@lambdageek lambdageek mentioned this pull request May 13, 2020
Merged
@safern safern force-pushed the DisableEventLogTest branch from 258615b to d6a5f17 Compare May 13, 2020 17:36
@safern safern changed the title Disable System.Diagnostics.Tests.EventLogSourceCreationTests.CheckSourceExistenceAndDeletion Disable System.Diagnostics.Tests.EventLogSourceCreationTests May 13, 2020
@safern
Copy link
Member Author

safern commented May 13, 2020

Spoke with @Anipik offline. We will disable with ActiveIssue and keep the issue open as it seems like the failures are related to machine state, so he'll investigate and look to how fix the tests.

@safern safern merged commit 2f75e69 into dotnet:master May 13, 2020
@safern safern deleted the DisableEventLogTest branch May 13, 2020 21:29
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

@Anipik Anipik Anipik approved these changes

Assignees
No one assigned
Labels
area-System.Diagnostics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@safern @ViktorHofer @Anipik @Dotnet-GitSync-Bot