Move StrongNameKeyId=Open default value down after arcade is imported #34428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I mentioned the same here : #34208 (comment) |
ericstj
approved these changes
Apr 2, 2020
maryamariyan
approved these changes
Apr 2, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in: 87e7991 we moved down the StrongNameKeyId for
Microsoft.Extensions.*projects. However for projects in libraries that don't declare aStrongNameKeyIdwe default it toOpen, but our declaration of its default value, also has the ordering problem, so arcade would set their defaultStrongNameKeyIdfor any projects in libraries that doesn't set this property and meaning to useOpenas the key id.cc: @ericstj @maryamariyan @ViktorHofer