Clean up normalizeLocale for mono browser target #112575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the removal of HybridLocalization in PR #110567 the following code was introduced into globalization-locale.ts
Firstly, the Chinese language check should be a check of
startsWith(
the prefix"zh-"
, notinclude(
the more ambiguous"zh"
. This could lead to problems if someone was using the substring zh in any of the other parts of the locale string. To ensure this works with locales formatted with underscores, we need to move up thatlocale.replace("_", "-")
to the first line.Secondly, per RFC 5646 the script code should be upper-case initial letter and lower-case the rest, so the replacement constants should be
"Hans"
and"Hant"
respectively. Also, since those replacement patterns for those subparts are supposed to be targeting the script indicator, it would be much safer to include the'-'
prefix.Fixes #112573