Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong size used for vectorization check in BitArray #111558

Closed
PranavSenthilnathan opened this issue Jan 17, 2025 · 3 comments · Fixed by #111564
Closed

Wrong size used for vectorization check in BitArray #111558

PranavSenthilnathan opened this issue Jan 17, 2025 · 3 comments · Fixed by #111564
Labels
area-System.Collections good first issue Issue should be easy to implement, good for first-time contributors in-pr There is an active PR which will close this issue when it is merged tenet-performance Performance related issue
Milestone
10.0.0

Comments

@PranavSenthilnathan
Copy link
Member

Vector512 should be Vector128:

runtime/src/libraries/System.Collections/src/System/Collections/BitArray.cs

Line 888 in a73f163

else if (Ssse3.IsSupported && ((uint)m_length >= Vector512<byte>.Count * 2u))

Found by @saucecontrol
@PranavSenthilnathan PranavSenthilnathan added area-System.Collections good first issue Issue should be easy to implement, good for first-time contributors labels Jan 17, 2025
@PranavSenthilnathan PranavSenthilnathan added this to the 10.0.0 milestone Jan 17, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

@stephentoub
Copy link
Member

This ends up only being a performance bug, not functional / reliability, correct? We'll end up falling back to the scalar path more often than we otherwise could?

@saucecontrol
Copy link
Member

saucecontrol commented Jan 17, 2025 •
edited
Loading

Yep, that's all. I suggested it as a good first PR on the community discord.

@jkotas jkotas changed the title Wrong size used for bounds check in BitArray Wrong size used for vectorization check in BitArray Jan 17, 2025
@jkotas jkotas added the tenet-performance Performance related issue label Jan 17, 2025
AnsBalin added a commit to AnsBalin/runtime that referenced this issue Jan 18, 2025
@AnsBalin
Fix size used for vectorization check in BitArray (dotnet#111558)
af1ae1f
@AnsBalin AnsBalin mentioned this issue Jan 18, 2025
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jan 18, 2025
AnsBalin added a commit to AnsBalin/runtime that referenced this issue Feb 11, 2025
@AnsBalin
Fix size used for vectorization check in BitArray (dotnet#111558)
4f5ae83
AnsBalin added a commit to AnsBalin/runtime that referenced this issue Feb 11, 2025
@AnsBalin
Fix size used for vectorization check in BitArray (dotnet#111558)
f5a0bbf
AnsBalin added a commit to AnsBalin/runtime that referenced this issue Feb 11, 2025
@AnsBalin
Fix size used for vectorization check in BitArray (dotnet#111558)
b3e4f10
AnsBalin added a commit to AnsBalin/runtime that referenced this issue Feb 12, 2025
@AnsBalin
Fix size used for vectorization check in BitArray (dotnet#111558)
f217968
jkotas pushed a commit that referenced this issue Feb 16, 2025
@AnsBalin @eiriktsarpalis
Fix size used for vectorization check in BitArray (#111558) (#111564)
e334a1a 
Co-authored-by: Eirik Tsarpalis <[email protected]>
grendello added a commit to grendello/runtime that referenced this issue Feb 18, 2025
@grendello
Merge branch 'main' into dev/grendel/android-clr-host-local
e7e5f61 
* main: (71 commits)
  Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250212.3 (dotnet#112626)
  JIT: Unify struct arg morphing (dotnet#112612)
  Enable `SA1015`: Closing generic bracket should not be followed by a space (dotnet#112597)
  Clean up normalizeLocale for mono browser target (dotnet#112575)
  SPMI: Ensure proper zero extension for isObjectImmutable and friends (dotnet#112617)
  Quote --version-scripts path (dotnet#112603)
  Remove incompatible API from PKCS netstandard2.0 lib
  [main] Update dependencies from dotnet/emsdk (dotnet#112393)
  Avoid `Unsafe.As` in `RangeCharSearchValues` (dotnet#112606)
  Fixed the issue of incorrect return value of PalVirtualAlloc (dotnet#112579)
  Fix size used for vectorization check in BitArray (dotnet#111558) (dotnet#111564)
  Fix build of windows arm64 crossdac (dotnet#112553)
  Simplify `ShuffleTakeIterator.GetCount` (dotnet#112593)
  Fix VS div-by-0 in DacEnumerableHashTable code (dotnet#112542)
  R2RDump: normalize GC info totalInterruptibleLength (dotnet#112003)
  Fix alignment padding and add test for saving managed resources (dotnet#110915)
  Adds `ccmp` logic into emitter backend. (dotnet#112153)
  Disable AVX10.2 by default (dotnet#112572)
  Outbox AesGcm in to Microsoft.Bcl.Cryptography
  Make test `IUnknown` conforming (dotnet#112566)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.Collections good first issue Issue should be easy to implement, good for first-time contributors in-pr There is an active PR which will close this issue when it is merged tenet-performance Performance related issue
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Fix size used for vectorization check in BitArray (#111558) AnsBalin/runtime
4 participants
@stephentoub @jkotas @saucecontrol @PranavSenthilnathan