Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] Change some workflows using pull_request to use pull_request_target instead #112164

Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 5, 2025

Backport of #112161 to release/9.0-staging

/cc @carlossanlop @jeffhandley

Infra change, tell-mode.

akoeplinger and others added 21 commits January 15, 2025 11:01
…websites.net (#111402)

* Disable more tests dependent on http://corefx-net-http11.azurewebsites.net (#111354)

* Disable more tests dependent on http://corefx-net-http11.azurewebsites.net

* Disable winhttphandlertests

* Disable tests using http://corefx-net-http11.azurewebsites.net (#111235)

Disabling until HTTPS redirection can be turned off at the server.
* [wasm] Re-enable skiasharp WBT tests

* Disable Debug/AOT combination

That would trigger build error, because we don't support that combination
anymore
…removal (#111508)

* [NRBF] Reduce the most time-consuming test case to avoid timeouts for checked builds (#110550)

* don't run drawing tests on Mono (#111208)

* don't run Drawing-related tests that do things like creating Bitmaps on Mono, as it's not supported (it does not support ComWrappers)

* re-enable the tests
[manual] Merge branch 'release/9.0' => 'release/9.0-staging'
…d sigs. (#111648) (#111675)

* Consume custom modifiers and ByRef in RetType signature
prior to comparing field signature.
* fix stack 2x2 tensor along dimension 1

* fixed last stack errors

---------

Co-authored-by: kasperk81 <[email protected]>
Co-authored-by: Michael Sharp <[email protected]>
…read static variables (#111275)

* Fix issue 110837

There was a race condition where we could have collected all of the managed state of a LoaderAllocator, but not yet started cleaning up the actual LoaderAllocator object in native code. If a thread which had a TLS variable defined in a code associated with a collectible loader allocator was terminated at that point, then the runtime would crash.

The fix is to detect if the LoaderAllocator managed state is still alive, and if so, do not attempt to clean it up.

* Disable test on NativeAOT

* Update src/tests/Loader/CollectibleAssemblies/Statics/CollectibleTLSStaticCollection.cs

Co-authored-by: Copilot <[email protected]>

* Update src/tests/Loader/CollectibleAssemblies/Statics/CollectibleTLSStaticCollection.cs

Co-authored-by: Copilot <[email protected]>

* Fix missing adjustment missed by copilot

---------

Co-authored-by: David Wrighton <[email protected]>
Co-authored-by: Copilot <[email protected]>
…NO-MERGE` label is applied (#111961)

* Add workflow to prevent merging a PR when the `NO-MERGE` label is applied.

* Invert condition

* Fix backtick bug in check-service-labels echo.

---------

Co-authored-by: Carlos Sánchez López <[email protected]>
* Fix UNC paths

If the input file was a network path then the raw path returned by
GetFinalPathByHandle may return a UNC path. If so, and if the original
path wasn't a UNC path, and the original path doesn't need normalization,
we want to use the original path.

* Use MAXPATH instead

* Update src/native/corehost/hostmisc/pal.windows.cpp

Co-authored-by: Elinor Fung <[email protected]>

* Update src/native/corehost/hostmisc/pal.windows.cpp

Co-authored-by: Elinor Fung <[email protected]>

---------

Co-authored-by: Andy Gocke <[email protected]>
Co-authored-by: Elinor Fung <[email protected]>
…mory (#111069)

* [mono] [llvm-aot] Fixed storing Vector3 into memory

* Removed unused variable

---------

Co-authored-by: Jeremi Kurdek <[email protected]>
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 5, 2025
@carlossanlop
Copy link
Member

carlossanlop commented Feb 5, 2025

Per #112161 (review) we don't need to backport.

Edit: This was incorrect, we do need to backport. But I will target the release/9.0 branch instead so we can flow quickly to staging.

@carlossanlop carlossanlop deleted the backport/pr-112161-to-release/9.0-staging branch February 5, 2025 01:10
@carlossanlop carlossanlop restored the backport/pr-112161-to-release/9.0-staging branch February 6, 2025 17:57
@carlossanlop carlossanlop reopened this Feb 6, 2025
@carlossanlop carlossanlop changed the base branch from release/9.0-staging to release/9.0 February 6, 2025 17:58
@carlossanlop
Copy link
Member

Chaging branch was a mess. I'll open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants