[release/9.0-staging] Re-enable skiasharp WBT tests (#109232) #110734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [wasm] Re-enable skiasharp WBT tests * Disable Debug/AOT combination That would trigger build error, because we don't support that combination anymore * Change order of native libs Put NativeFileReference files after the runtime libs. This server as a workaround of dotnet#109289 * Update llvm, emsdk and icu deps * Revert "Change order of native libs" This reverts commit e320fd6.
dotnet-issue-labeler
bot
added
the
needs-area-label
radekdoulik
added
area-Infrastructure-mono
and removed
needs-area-label
|
Tagging subscribers to this area: @akoeplinger, @matouskozak |
ilonatommy
approved these changes
Dec 16, 2024
jeffschwMSFT
approved these changes
Jan 9, 2025
|
@radekdoulik is this ready to merge? It would be nice to have these test fixes included in the release to get cleaner CI results in the base and internal branches. |
yeah, it is ready. the re-enabled tests pass, so this should make CI happy and confirm the llvm changes are in place and working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #109232 to release/9.0-staging
Customer Impact
The linker problem, which was found internally when re-enabling skiasharp tests. The problem was already resolved by the llvm update in #110409
Regression
Testing
This PR enables the relevant tests on CI, to confirm the llvm fix works fine on 9.0 branch.
Risk
Low risk, this PR enables CI tests only.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.
Resolves #103566