Skip to content

Commit

Permalink
Disable System.Diagnostics.Tests.EventLogSourceCreationTests (#36138)
Browse files Browse the repository at this point in the history
* Disable System.Diagnostics.Tests.EventLogSourceCreationTests.CheckSourceExistenceAndDeletion

* Fix trait to skip tests in CI

* Use ActiveIssue instead
  • Loading branch information
safern authored May 13, 2020
1 parent 6ba9499 commit 2f75e69
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace System.Diagnostics.Tests
{
public class EventLogSourceCreationTests
{
[Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
[ActiveIssue("https://github.com/dotnet/runtime/issues/36135")]
[ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
public void CheckSourceExistenceAndDeletion()
{
Expand All @@ -29,7 +29,7 @@ public void CheckSourceExistenceAndDeletion()
Assert.False(EventLog.SourceExists(source));
}

[Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
[ActiveIssue("https://github.com/dotnet/runtime/issues/36135")]
[ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
public void LogNameWithSame8FirstChars_NetCore()
Expand All @@ -56,7 +56,7 @@ public void LogNameWithSame8FirstChars_NetCore()
}
}

[Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
[ActiveIssue("https://github.com/dotnet/runtime/issues/36135")]
[ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
[SkipOnTargetFramework(~TargetFrameworkMonikers.NetFramework)]
public void LogNameWithSame8FirstChars_NetFramework()
Expand Down Expand Up @@ -145,7 +145,7 @@ public void SourceDataNull()
Assert.Throws<ArgumentNullException>(() => EventLog.CreateEventSource(null));
}

[Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
[ActiveIssue("https://github.com/dotnet/runtime/issues/36135")]
[ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
public void SourceAlreadyExistsWhenCreatingSource()
{
Expand Down

0 comments on commit 2f75e69

Please sign in to comment.