Remove Edgio CDN usage to release/dev17.8 #76604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
reviewed
Jan 4, 2025
eng/Versions.props
Outdated
| @@ -316,7 +316,7 @@ | |||
| When updating the S.C.I or S.R.M version please let the MSBuild team know in advance so they | |||
| can update to the same version. Version changes require a VS test insertion for validation. | |||
| --> | |||
| <SystemCollectionsImmutableVersion>7.0.0</SystemCollectionsImmutableVersion> | |||
| <SystemCollectionsImmutableVersion>8.0.0</SystemCollectionsImmutableVersion> | |||
There was a problem hiding this comment.
I'm not 100% certain we can do this - what triggered the upgrade here? If VS 17.8 itself isn't on 8.0 I believe we'll have issues
There was a problem hiding this comment.
MSBuildStructuredLoggerVersion version 2.2.386 depends on this according to the CI error message. Maybe we can try with a lower MSBuildStructuredLoggerVersion?
There was a problem hiding this comment.
@jordi1215 yeah lets try a lower version. Try 2.2.350, if that doesn't work I can help get other versions added so restore works
…ableVersion version
…t doesn't require 8.0 Immutable collections
dibarbet
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are copied over from #76431