-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Edgio CDN usage #76431
Merged
Merged
Remove Edgio CDN usage #76431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -19,7 +19,7 @@ public IFileDownloader CreateClient(string hostId, string serverPath, int pollin | |||
{ | |||
// BaseUrl provided by the VS RemoteControl client team. This is URL we are supposed | |||
// to use to publish and access data from. | |||
const string BaseUrl = "https://az700632.vo.msecnd.net/pub"; | |||
const string BaseUrl = "https://aka.ms/vssettings/pub"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd like to debug through this to make sure this works :) i can do so tomorrow.
jasonmalinowski
approved these changes
Dec 14, 2024
CyrusNajmabadi
approved these changes
Dec 16, 2024
I have confirmed this works. |
arunchndr
added a commit
that referenced
this pull request
Dec 16, 2024
The changes are copied over from a PR to release/dev17.12 #76431
Known flaky failure in options test. Unrelated. Tomas looking at the test in question separately. |
phil-allen-msft
added a commit
that referenced
this pull request
Dec 17, 2024
This was referenced Jan 2, 2025
dibarbet
added a commit
that referenced
this pull request
Jan 6, 2025
The changes are copied over from #76431
dibarbet
added a commit
that referenced
this pull request
Jan 7, 2025
The changes are copied over from #76431
dibarbet
added a commit
that referenced
this pull request
Jan 7, 2025
The changes are copied over from #76431
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to auto roll forward into 17.13 as well.
@jordi1215 and @phil-allen-msft in relation to branch lock.