Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsFileLocal lightup, use it in CA1708 #7190

Merged
merged 10 commits into from
Feb 17, 2024
Merged

Add IsFileLocal lightup, use it in CA1708 #7190

merged 10 commits into from
Feb 17, 2024

Conversation

RenderMichael
Copy link
Contributor

Fixes #6514

@RenderMichael RenderMichael requested a review from a team as a code owner February 12, 2024 08:14
@codecov Codecov
Copy link

codecov bot commented Feb 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90721b0) 96.45% compared to head (8d53933) 96.44%.

❗ Current head 8d53933 differs from pull request most recent head 92830ba. Consider uploading reports for the commit 92830ba to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7190      +/-   ##
==========================================
- Coverage   96.45%   96.44%   -0.02%     
==========================================
  Files        1422     1415       -7     
  Lines      340539   338237    -2302     
  Branches    11230    11191      -39     
==========================================
- Hits       328470   326211    -2259     
+ Misses       9231     9207      -24     
+ Partials     2838     2819      -19

@RenderMichael RenderMichael mentioned this pull request Feb 13, 2024
Closed
@RenderMichael
Copy link
Contributor Author

Just realized I never added that [WorkItem] attribute, is it important @sharwell ?

@sharwell sharwell enabled auto-merge February 14, 2024 22:36
@sharwell sharwell merged commit ab13ac7 into dotnet:main Feb 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

Assignees
No one assigned
Labels
Community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File-Scoped Types With The Same Name Trigger CA1708
2 participants
@RenderMichael @sharwell