Further PR feedback

dotnet · Feb 14, 2024 · 8d53933 · 8d53933
1 parent 5339702
commit 8d53933
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/...rosoft.CodeQuality.Analyzers/ApiDesignGuidelines/IdentifiersShouldDifferByMoreThanCase.cs b/...rosoft.CodeQuality.Analyzers/ApiDesignGuidelines/IdentifiersShouldDifferByMoreThanCase.cs
@@ -97,9 +97,9 @@ private static void CheckNamespaceMembers(IEnumerable<INamespaceSymbol> namespac
             {
                 // Get all the potentially externally visible types in the namespace
                 IEnumerable<INamedTypeSymbol> typeMembers = @namespace.GetTypeMembers().Where(item =>
-                Equals(item.ContainingAssembly, context.Compilation.Assembly) &&
-                MatchesConfiguredVisibility(item, context.Options, context.Compilation) &&
-                !item.IsFileLocal());
+                    Equals(item.ContainingAssembly, context.Compilation.Assembly) &&
+                    MatchesConfiguredVisibility(item, context.Options, context.Compilation) &&
+                    !item.IsFileLocal());
 
                 if (typeMembers.Any())
                 {

diff --git a/src/Utilities/Compiler/Extensions/INamedTypeSymbolExtensions.cs b/src/Utilities/Compiler/Extensions/INamedTypeSymbolExtensions.cs
@@ -14,6 +14,11 @@ namespace Analyzer.Utilities.Extensions
 {
     internal static class INamedTypeSymbolExtensions
     {
+
+        private static readonly Func<INamedTypeSymbol, bool> s_isFileLocal = LightupHelpers.CreateSymbolPropertyAccessor<INamedTypeSymbol, bool>(typeof(INamedTypeSymbol), nameof(IsFileLocal), fallbackResult: false);
+
+        public static bool IsFileLocal(this INamedTypeSymbol symbol) => s_isFileLocal(symbol);
+
         public static IEnumerable<INamedTypeSymbol> GetBaseTypesAndThis(this INamedTypeSymbol type)
         {
             INamedTypeSymbol current = type;
@@ -283,9 +288,5 @@ public static bool IsBenchmarkOrXUnitTestAttribute(this INamedTypeSymbol attribu
         public static bool IsTopLevelStatementsEntryPointType([NotNullWhen(true)] this INamedTypeSymbol? typeSymbol)
             => typeSymbol is not null &&
                typeSymbol.GetMembers().OfType<IMethodSymbol>().Any(m => m.IsTopLevelStatementsEntryPointMethod());
-
-        private static readonly Func<INamedTypeSymbol, bool> s_isFileLocal = LightupHelpers.CreateSymbolPropertyAccessor<INamedTypeSymbol, bool>(typeof(INamedTypeSymbol), nameof(IsFileLocal), fallbackResult: false);
-
-        public static bool IsFileLocal(this INamedTypeSymbol symbol) => s_isFileLocal(symbol);
     }
 }