Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Update resizetizer for Tizen for Net6 #8797

Merged
merged 8 commits into from
Jul 19, 2022

Conversation

JoonghyunCho
Copy link
Contributor

Description of Change

This PR adds shared manifest features, fixing a bug and enhancing logic to allow incremental builds for Tizen.

  1. Adding Shared Manifest
    Maui shared app manifest properties now applies to Tizen.
  • ApplicationTitle, ApplicationId and ApplicationDisplayVersion values will be applied to tizen-manifest.xml
  • ApplicationVersion will be ignored as it does not fit to Tizen.
  1. Fixing a bug
    Removing unnecessary original splash images from packaging.

  2. Enhancing behavior

  • Use timestamp to prevent unnecessary regeneration of tizen-manifest.xml.
  • Copy tizen-manifest.xml file to obj directory and update/package file instead of overwrite it in working directory.
  • Only update shared app manifest information back to original tizen-manifest.xml .

@JoonghyunCho JoonghyunCho requested a review from a team as a code owner July 18, 2022 03:27
@jsuarezruiz jsuarezruiz added the partner/tizen Samsung Tizen Team label Jul 18, 2022
@mattleibow
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mattleibow
Copy link
Member

This appears to be the same changes as this PR: #8298

We can close that one as these changes will get merged up.

@Eilon Eilon added the area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer label Jul 18, 2022
@mattleibow
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@rookiejava rookiejava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your efforts!

@rmarinho rmarinho merged commit dd49e52 into dotnet:net6.0 Jul 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
@samhouts samhouts added fixed-in-7.0.0-rc.1.6683 fixed-in-6.0.486 Look for this fix in 6.0.486 SR4! labels Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer fixed-in-6.0.486 Look for this fix in 6.0.486 SR4! fixed-in-7.0.0-rc.1.6683 partner/tizen Samsung Tizen Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants