Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Update resizetizer for Tizen #8298

Closed
wants to merge 7 commits into from

Conversation

JoonghyunCho
Copy link
Contributor

Description of Change

This PR adds shared manifest features, fixing a bug and enhancing logic to allow incremental builds for Tizen.

  1. Adding Shared Manifest
    Maui shared app manifest properties now applies to Tizen.
  • ApplicationTitle, ApplicationId and ApplicationDisplayVersion values will be applied to tizen-manifest.xml
  • ApplicationVersion will be ignored as it does not fit to Tizen.
  1. Fixing a bug
    Removing unnecessary original splash images from packaging.

  2. Enhancing behavior

  • Use timestamp to prevent unnecessary regeneration of tizen-manifest.xml.
  • Copy tizen-manifest.xml file to obj directory and update/package file instead of overwrite it in working directory.
  • Only update shared app manifest information back to original tizen-manifest.xml .

@JoonghyunCho JoonghyunCho changed the title Update resizetizer [Tizen] Update resizetizer for Tizen Jun 24, 2022
@jsuarezruiz jsuarezruiz added the platform/tizen Samsung Tizen Devices (TV) label Jun 24, 2022
@Eilon Eilon added the area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer label Jun 24, 2022
@mattleibow
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mattleibow mattleibow added this to the .NET 7 milestone Jun 24, 2022
@mattleibow mattleibow self-assigned this Jun 24, 2022
@JoonghyunCho JoonghyunCho requested a review from a team as a code owner June 30, 2022 08:58
@rmarinho
Copy link
Member

rmarinho commented Jul 1, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@JoonghyunCho
Copy link
Contributor Author

Seems like the check is failed. I will test and update.

@JoonghyunCho
Copy link
Contributor Author

@rmarinho sorry for the issue. Please /azp run again. Thanks

@JoonghyunCho JoonghyunCho requested a review from mattleibow July 7, 2022 02:11
@JoonghyunCho
Copy link
Contributor Author

@mattleibow Just want to raise up an attention :) Please check

@JoonghyunCho
Copy link
Contributor Author

Created the same changes against net6.0 on #8797

@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer platform/tizen Samsung Tizen Devices (TV)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants