Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Titlebar visibility when backbutton is present #7932

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

PureWeen
Copy link
Member

Description of Change

On windows don't display the titlebar if only the backbutton is present. The backbutton isn't part of the toolbar

Issues Fixed

Fixes #7198

@PureWeen PureWeen requested a review from SotoiGhost June 10, 2022 16:46
@PureWeen PureWeen changed the title Fix titlebar backbutton Fix Titlebar visibility when backbutton is present Jun 10, 2022
@PureWeen PureWeen added this to the 6.0-sr2 milestone Jun 15, 2022
Copy link
Contributor

@SotoiGhost SotoiGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@SotoiGhost
Copy link
Contributor

@PureWeen will this be part of sr2? If so, I think this should be retargeted to the net6.0 branch

@PureWeen PureWeen changed the base branch from main to net6.0 June 15, 2022 17:05
@PureWeen PureWeen merged commit f8f23f4 into net6.0 Jun 15, 2022
@PureWeen PureWeen deleted the fix_titlebar_backbutton branch June 15, 2022 17:05
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
@samhouts samhouts added the fixed-in-6.0.408 Look for this fix in 6.0.408! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.408 Look for this fix in 6.0.408!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the title set to string empty place for title is still exist
3 participants