Don't tie toolbar to backbutton on windows (#7932)

dotnet · Jun 15, 2022 · f8f23f4 · f8f23f4
1 parent 8604b3c
commit f8f23f4
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/src/Controls/src/Core/ShellToolbar.cs b/src/Controls/src/Core/ShellToolbar.cs
@@ -113,8 +113,7 @@ internal void ApplyChanges()
 			{
 				var flyoutBehavior = (_shell as IFlyoutView).FlyoutBehavior;
 #if WINDOWS
-				IsVisible = (BackButtonVisible ||
-					!String.IsNullOrEmpty(Title) ||
+				IsVisible = (!String.IsNullOrEmpty(Title) ||
 					TitleView != null ||
 					_toolbarTracker.ToolbarItems.Count > 0 ||
 					_menuBarTracker.ToolbarItems.Count > 0 ||

diff --git a/src/Controls/tests/DeviceTests/Elements/Shell/ShellTests.Windows.cs b/src/Controls/tests/DeviceTests/Elements/Shell/ShellTests.Windows.cs
@@ -437,5 +437,25 @@ await CreateHandlerAndAddToWindow<ShellHandler>(shell, (handler) =>
 				return Task.CompletedTask;
 			});
 		}
+
+
+		// this is only relevant on windows where the title/backbutton aren't in the same
+		// area
+		[Fact(DisplayName = "Shell Toolbar not visible when only back button is present")]
+		public async Task ShellToolbarNotVisibleWhenOnlyBackButtonIsPresent()
+		{
+			SetupBuilder();
+
+			var shell = await CreateShellAsync((shell) =>
+			{
+				shell.CurrentItem = new ContentPage();
+			});
+
+			await CreateHandlerAndAddToWindow<ShellHandler>(shell, async (handler) =>
+			{
+				await shell.Navigation.PushAsync(new ContentPage());
+				Assert.False(IsNavigationBarVisible(handler));
+			});
+		}
 	}
 }