Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android NamedSize.Header changed from 96 to 14 #7433

Merged
merged 1 commit into from
May 24, 2022

Conversation

beeradmoore
Copy link
Contributor

Description of Change

This used to be a bug in Xamarin.Forms when running on Android that the font size for NamedSize.Header font was 96, this was later dropped to 14.

MAUI is using 96. This PR brings it back down to 14 to match incoming Xamarin.Forms users.

Issues Fixed

Fixes #7428

@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rmarinho
Copy link
Member

Do we use this on MAUI outiside Compatibility ?

@beeradmoore
Copy link
Contributor Author

beeradmoore commented May 24, 2022

Do we use this on MAUI outiside Compatibility ?

Most probably not. I searched the docs and came up empty. I then used google site search and the only reference is in FontImage for xaml markup.

Size of type double, the size, in device-independent units, of the rendered font icon. The default value is 30. In addition, this property can be set to a named font size.

Document for Label even only says

FontSize, of type double, defines the font size.

EDIT:
Even the file for NamedSize marked it as obsolete. The only reason it doesn't show up in builds is because the warning is suppressed in multiple places.

There is no info on what we should be doing instead, I assume people should be defining styles and moving away from NamedSize (if we are using it, I am not) ?

@rmarinho rmarinho merged commit 05dd179 into dotnet:main May 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.400 Look for this fix in 6.0.400! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.400 Look for this fix in 6.0.400!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label with FontSize="Header" is enormous on Android and tiny on iOS
4 participants