Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

NamedSize.Header seems to be wrong size on Android #11194

Closed
bokmadsen opened this issue Jun 25, 2020 · 3 comments · Fixed by #12983
Closed

NamedSize.Header seems to be wrong size on Android #11194

bokmadsen opened this issue Jun 25, 2020 · 3 comments · Fixed by #12983
Labels
a/fonts e/1 🕐 1 good first issue hacktoberfest 🍻 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛

Comments

@bokmadsen
Copy link

On Android the NamedSize.Header is way larger than any other named size. Header is 96 and Title is only 24. I think that's is a bug:

Xamarin.Forms/Xamarin.Forms.Platform.Android/Forms.cs

Line 705 in 5062f53

case NamedSize.Header:

Xamarin.Forms/Xamarin.Forms.Platform.Android/Forms.cs

Line 737 in 5062f53

case NamedSize.Header:

@jsuarezruiz jsuarezruiz added p/Android s/unverified New report that has yet to be verified t/bug 🐛 labels Jun 25, 2020
@rmarinho
Copy link
Member

rmarinho commented Jul 2, 2020

Hey @jfversluis where did we got these values?

@rmarinho rmarinho added the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Jul 2, 2020
@jfversluis
Copy link
Member

There isn't really a 1:1 mapping, looking at #6591, I used this link: https://material.io/develop/android/theming/typography/ and took the textAppearanceHeadline1 one

@samhouts samhouts removed the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Aug 3, 2020
@PureWeen
Copy link
Contributor

PureWeen commented Aug 8, 2020

The 96 choice does seem really high especially when compared to iOS and UWP

iOS is going to be about 17 and UAP is 46

96 is massive... I realize it's a breaking change but if possible it seems like we'd just set Android to something around 17 as well.

image

@PureWeen PureWeen added good first issue e/1 🕐 1 and removed s/unverified New report that has yet to be verified labels Aug 8, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts removed this from the 5.0.0 milestone Nov 2, 2020
@jsuarezruiz jsuarezruiz mentioned this issue Nov 27, 2020
Merged
2 tasks
@jsuarezruiz jsuarezruiz added the in-progress This issue has an associated pull request that may resolve it! label Nov 27, 2020
@beeradmoore beeradmoore mentioned this issue May 24, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a/fonts e/1 🕐 1 good first issue hacktoberfest 🍻 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Android] Update Font Header size xamarin/Xamarin.Forms
6 participants
@bokmadsen @jfversluis @rmarinho @PureWeen @jsuarezruiz @samhouts