Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add VC Redist dependency to Windows templates" #6758

Merged
merged 1 commit into from
May 3, 2022

Conversation

jfversluis
Copy link
Member

Reverts #6318

This reverts adding the VS Redist dependencies to the Windows Package.appxmanifest. The dependency on C++ bits has been removed from the Win2D package as of version 1.0.3.1 which we add through Microsoft.Maui.Graphics

@jfversluis jfversluis added platform/windows 🪟 area-publishing Issues with the app packaging/publishing process (ipk/apk/msix/trimming) labels May 2, 2022
@jfversluis jfversluis requested a review from mattleibow May 2, 2022 18:10
@jfversluis
Copy link
Member Author

Marking as draft until we merged the Graphics side

@mattleibow
Copy link
Member

Just a comment. In the graphics pr, you just bumped the nuspec. We're the csproj and other places all up to date?

@jfversluis
Copy link
Member Author

@mattleibow did that now: dotnet/Microsoft.Maui.Graphics#415

@jfversluis
Copy link
Member Author

Waiting for #6778

@jfversluis jfversluis marked this pull request as ready for review May 3, 2022 17:51
@jfversluis jfversluis requested a review from a team as a code owner May 3, 2022 17:51
@mattleibow mattleibow changed the base branch from main to release/6.0.3xx-rc3 May 3, 2022 18:02
@mattleibow mattleibow merged commit bb116a4 into release/6.0.3xx-rc3 May 3, 2022
@mattleibow mattleibow deleted the revert-6318-msix-work branch May 3, 2022 18:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.312 Look for this fix in 6.0.312! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-publishing Issues with the app packaging/publishing process (ipk/apk/msix/trimming) fixed-in-6.0.312 Look for this fix in 6.0.312! platform/windows 🪟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants