-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VC Redist dependency to Windows templates #6318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably related to the fact that the SDKReference things are not working. This should be added via the build process and not manually included as different VCLibs are used in Debug/Release.
Based on an exciting email thread around this, this is a result of a few things:
There is steps to solve this that I believe are happening as we speak but will not make it in time:
There is also some workaround for now:
Things that we cannot control:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added back the Microsoft.VCLibs.140.00
dependency in addition to the Microsoft.VCLibs.140.00.UWPDesktop
because I am not sure what they all do. The Windows App SDK adds both, so I am adding both.
It technically also adds the <build:Item Name="Microsoft.UniversalCRT.Debug" Version="10.0.19041.0" />
in another section, but I am feeling that is build time things maybe.
Unless someone can say the dependencies are bad in some way, this is what we will have and then once our dependencies are ready to be VCLibs-free, we can remove/comment out in the template for the general public.
And to make a comment on the Release/Debug differences... This is still a thing, but there is no way to do this in the manifests. It will need to be an additional step, but since Win2D is getting fixed in the future - and when you are running a debug app you also probably have VS or even just the VC Runtime installed. |
This reverts commit 3b713c3.
Description of Change
This adds the Visual C++ Redistributable libraries as a dependency to our Windows templates to light up the MSIX distributable scenario on non-dev machines.
By adding this the C++ redist will be added as a prerequisite and installed as part of installing the .NET MAUI app.
It seems this will also be fixed on the WinUI side (microsoft/WindowsAppSDK#2117) so when WinAppSdk 1.1 lands we might no longer need this.
Issues Fixed
NA