Switches to UIResponder for App/Scene delegates #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the proper inheritence chain and allows us to use things like overriding the BuildMenu method. This fixes #4390
Redth
requested review from
mattleibow,
PureWeen,
dalexsoto and
drasticactions
mattleibow
reviewed
Jan 28, 2022
drasticactions
approved these changes
Jan 28, 2022
|
Just a note that this is a massive breaking change for anyone that has any extension methods or parameters that took the concrete class, but this is definitely a more future-proof interface to use. Should we ever actually use the concrete type for extensions/parameters? It is an iOS protocol after all. |
mattleibow
approved these changes
Jan 29, 2022
|
Maybe this should be made |
ghost
mentioned this pull request
samhouts
added
the
fixed-in-6.0.200-preview.13.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proper inheritence chain and allows us to use things like overriding the BuildMenu method.
This fixes #4390