Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS and MacCatalyst MauiApplicationDelegate should derive from UIResponder #4390

Closed
2 tasks
Redth opened this issue Jan 28, 2022 · 0 comments · Fixed by #4391
Closed
2 tasks

iOS and MacCatalyst MauiApplicationDelegate should derive from UIResponder #4390

Redth opened this issue Jan 28, 2022 · 0 comments · Fixed by #4391
Assignees
@Redth
Labels
area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer fixed-in-6.0.200-preview.13.2 Look for this fix in 6.0.200-preview.13.2! platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst t/bug Something isn't working

Comments

@Redth
Copy link
Member

Redth commented Jan 28, 2022

Description

See: https://github.com/xamarin/xamarin-templates/commit/088e308ae7ae3982f04f31a53d32dd4dadb6253c

In order to override things like BuildMenu, the app delegate really needs to derive from UIResponder instead of UIApplicationDelegate, but it should implement IUIApplicationDelegate.

  • Update MauiUIApplicationDelegate to derive from UIResponder, IUIApplicationDelegate
  • Update the templates if/as necessary (probably need some [Export] attributes for things overridden)

Steps to Reproduce

.

Version with bug

Preview 12 (current)

Last version that worked well

Unknown/Other

Affected platforms

iOS, macOS

Affected platform versions

.

Did you find any workaround?

No response

Relevant log output

No response
@Redth Redth added t/bug Something isn't working area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer labels Jan 28, 2022
@Redth Redth self-assigned this Jan 28, 2022
Redth added a commit that referenced this issue Jan 28, 2022
@Redth
Switches to UIResponder for App/Scene delegates
ed7460c 
This is the proper inheritence chain and allows us to use things like overriding the BuildMenu method.

This fixes #4390
@Redth Redth mentioned this issue Jan 28, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 1, 2022
@samhouts samhouts added the fixed-in-6.0.200-preview.13.2 Look for this fix in 6.0.200-preview.13.2! label Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Redth Redth

Labels
area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer fixed-in-6.0.200-preview.13.2 Look for this fix in 6.0.200-preview.13.2! platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst t/bug Something isn't working
Projects
No open projects
[ARCHIVED] MAUI Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switches to UIResponder for App/Scene delegates dotnet/maui
2 participants
@Redth @samhouts