Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uitests] Add UITests for RefreshView #16528

Closed
wants to merge 5 commits into from
Closed

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Aug 3, 2023

Description of Change

Adding more testing to validate fixes on #14302

Add UITest for issue #11327

@rmarinho rmarinho added the area-testing Unit tests, device tests label Aug 3, 2023
namespace Maui.Controls.Sample.Issues
{
[Issue(IssueTracker.Github, 11327, "Incorrect layout with GridItemsLayout and RefreshView", PlatformAffected.iOS)]
public class Issue11327 : TestContentPage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: Issue11327Test.png (size differs - baseline is 1080x2280 pixels, actual is 1080x1860 pixels)

Should the test only runs on some specific devices?

@rmarinho rmarinho force-pushed the refreshview-uitests branch from 2f12b61 to 97a1454 Compare August 4, 2023 16:57
@samhouts samhouts added this to the .NET 8 GA milestone Aug 29, 2023
@samhouts samhouts added stale Indicates a stale issue/pr and will be closed soon s/pr-needs-author-input PR needs an update from the author labels Sep 14, 2023
@ghost
Copy link

ghost commented Sep 14, 2023

Hi @rmarinho. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

@ghost ghost closed this Sep 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests s/pr-needs-author-input PR needs an update from the author stale Indicates a stale issue/pr and will be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants