Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Make sure to update the frame of the RefreshView content #14302

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Mar 30, 2023

Description of Change

The MauiRefreshView on iOS wasn't updating the Frame of it's content,

Issues Fixed

Fixes #11327
Fixes #11363
Fixes #12188
Fixes #7315

@rmarinho
Copy link
Member Author

Still trying to figure how to write a test for this. Give me UITests!

@rmarinho rmarinho requested a review from hartez March 30, 2023 17:51
@rmarinho rmarinho requested a review from jsuarezruiz March 30, 2023 22:21
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Mar 31, 2023
@jsuarezruiz
Copy link
Contributor

Still trying to figure how to write a test for this. Give me UITests!

Would it be possible to create a device test where a RefreshView is attached, wait until the size is not empty and make an assertion that the height/width is not zero? If before the changes the app freezes, the test would not pass, right?

@rmarinho rmarinho changed the title [iOS] Make sure the update the frame of the RefreshView content [iOS] Make sure to update the frame of the RefreshView content Apr 1, 2023
@rmarinho rmarinho merged commit e2448f1 into main Apr 3, 2023
@rmarinho rmarinho deleted the fix-11363 branch April 3, 2023 16:50
@rmarinho rmarinho added the backport/suggested The PR author or issue review has suggested that the change should be backported. label Apr 3, 2023
@vpshonyak
Copy link

@rmarinho are you going to fix it in net6.0 and net7.0? Or just net8.0

@hartez
Copy link
Contributor

hartez commented Jul 5, 2023

@rmarinho are you going to fix it in net6.0 and net7.0? Or just net8.0

We're still reviewing whether we can backport this to 6 and 7; we have some testing infrastructure issues we need to address before we can safely do that.

@haavamoa
Copy link

haavamoa commented Aug 3, 2023

@rmarinho are you going to fix it in net6.0 and net7.0? Or just net8.0

We're still reviewing whether we can backport this to 6 and 7; we have some testing infrastructure issues we need to address before we can safely do that.

Was there a decision as if this should be backported? Unfortunately, this bug stops us from publishing our apps to costumers as of today.

@PureWeen PureWeen added the backport/NO This change should not be backported. It may break customers. label Sep 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-8.0.0-preview.4.8333 Look for this fix in 8.0.0-preview.4.8333! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-refreshview RefreshView backport/NO This change should not be backported. It may break customers. backport/suggested The PR author or issue review has suggested that the change should be backported. fixed-in-8.0.0-preview.4.8333 Look for this fix in 8.0.0-preview.4.8333! platform/iOS 🍎 t/bug Something isn't working
Projects
None yet
8 participants