[.NET] Proof-of-concept of removing ObjCRuntime.nfloat in favor of System.Runtime.InteropServices.NFloat. #13845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfbjarne
added
not-notes-worthy
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffView dotnet API diffView dotnet legacy API diffGenerator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results73 tests failed, 73 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
New commits in migueldeicaza/MonoTouch.Dialog: * migueldeicaza/MonoTouch.Dialog@3b9f579 Update code to cope with nfloat removal. Diff: https://github.com/migueldeicaza/MonoTouch.Dialog/compare/e8e0abe586fbe9351520704d3ca9480dc34ee77b..3b9f579868d4e53aefc12c30da0a3c0944ebbd69 New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@b5429b9 Update code to cope with nfloat removal. Diff: https://github.com/spouliot/Touch.Unit/compare/d668e4d99924acd04010c096029a8d3c7aed7586..b5429b9401dc1261f45671a52b3a5e9001240423
chamons
reviewed
Jan 28, 2022
| * Code that references the full typename, `System.nfloat` won't compile. | ||
|
|
||
| Fix: use `ObjCRuntime.nfloat` instead. | ||
| // TODO: explain more |
There was a problem hiding this comment.
Reminder before this goes live ^
| xamarin_NFloat_objc_msgSend_exception (id self, SEL sel, GCHandle *exception_gchandle) | ||
| { | ||
| @try { | ||
| #if defined(__i386__) |
There was a problem hiding this comment.
Do we expect NET6 + 32-bit to be a thing?
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
API Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
Generator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 143 tests passed.Failed tests
Pipeline on Agent XAMBOT-1097.BigSur' |
|
The final PR is up: #14197. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** DRAFT PR ** PROCEED AT OWN RISK **
This is just to get some CI on this.