Skip to content

Commit

Permalink
Fix more tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
rolfbjarne committed Jan 28, 2022
1 parent 35df9eb commit 9096a27
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 8 deletions.
18 changes: 10 additions & 8 deletions tests/common/DotNetGlobals.cs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#nullable enable

global using nfloat = System.Runtime.InteropServices.NFloat;
global using System.Runtime.InteropServices;

Expand Down Expand Up @@ -167,24 +169,24 @@ public static void AddLineToPoint (this CGPath self, CGAffineTransform transform
}

// CopyByDashingPath
public static CGPath CopyByDashingPath (this CGPath self, CGAffineTransform transform, float [] lengths)
public static CGPath CopyByDashingPath (this CGPath self, CGAffineTransform transform, float []? lengths)
{
return self.CopyByDashingPath (transform, NFloatHelpers.ConvertArray (lengths));
return self.CopyByDashingPath (transform, NFloatHelpers.ConvertArray (lengths)!);
}

public static CGPath CopyByDashingPath (this CGPath self, CGAffineTransform transform, float [] lengths, float phase)
public static CGPath CopyByDashingPath (this CGPath self, CGAffineTransform transform, float []? lengths, float phase)
{
return self.CopyByDashingPath (transform, NFloatHelpers.ConvertArray (lengths), new NFloat (phase));
return self.CopyByDashingPath (transform, NFloatHelpers.ConvertArray (lengths)!, new NFloat (phase));
}

public static CGPath CopyByDashingPath (this CGPath self, float [] lengths)
public static CGPath CopyByDashingPath (this CGPath self, float []? lengths)
{
return self.CopyByDashingPath (NFloatHelpers.ConvertArray (lengths));
return self.CopyByDashingPath (NFloatHelpers.ConvertArray (lengths)!);
}

public static CGPath CopyByDashingPath (this CGPath self, float [] lengths, float phase)
public static CGPath CopyByDashingPath (this CGPath self, float []? lengths, float phase)
{
return self.CopyByDashingPath (NFloatHelpers.ConvertArray (lengths), new NFloat (phase));
return self.CopyByDashingPath (NFloatHelpers.ConvertArray (lengths)!, new NFloat (phase));
}
}

Expand Down
4 changes: 4 additions & 0 deletions tests/linker/ios/link sdk/LinkSdkRegressionTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,11 @@ public static HardwareVersion Version {
ret = HardwareVersion.Unknown;
#else
if (UIDevice.CurrentDevice.Model.Contains("iPhone"))
#if NO_NFLOAT_OPERATORS
ret = UIScreen.MainScreen.Bounds.Height.Value * UIScreen.MainScreen.Scale.Value == 960 || UIScreen.MainScreen.Bounds.Width.Value * UIScreen.MainScreen.Scale.Value == 960 ? HardwareVersion.iPhone4Simulator : HardwareVersion.iPhoneSimulator;
#else
ret = UIScreen.MainScreen.Bounds.Height * UIScreen.MainScreen.Scale == 960 || UIScreen.MainScreen.Bounds.Width * UIScreen.MainScreen.Scale == 960 ? HardwareVersion.iPhone4Simulator : HardwareVersion.iPhoneSimulator;
#endif
else
ret = HardwareVersion.iPadSimulator;
#endif
Expand Down

5 comments on commit 9096a27

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

Generator Diff (no change)

Packages generated

View packages

Test results

10 tests failed, 225 tests passed.

Failed tests

  • dont link/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)
  • link all/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)
  • trimmode link/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 116 Passed: 106 Inconclusive: 0 Failed: 1 Ignored: 9)
  • trimmode link/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)
  • introspection/iOS Unified 64-bits - simulator/Debug (iOS 12.4) [dotnet]: TimedOut
  • introspection/iOS Unified 64-bits - simulator/Debug (iOS 12.4): TimedOut
  • introspection/tvOS - simulator/Debug (tvOS 12.4) [dotnet]: Failed
  • introspection/tvOS - simulator/Debug (tvOS 12.4): Failed
  • MSBuild tests/Integration: Failed (Execution failed with exit code 4)
  • DotNet tests: Failed (Execution failed with exit code 1)

Pipeline on Agent XAMBOT-1023.BigSur
Fix more tests.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (no summary found). 🔥

Result file D:\a\1\s\Reports\TestSummary-tvos\TestSummary.md not found.

Pipeline on Agent
Fix more tests.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (no summary found). 🔥

Result file D:\a\1\s\Reports\TestSummary-iOS64\TestSummary.md not found.

Pipeline on Agent
Fix more tests.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS M1 - Mac Big Sur (11.5) ✅

Tests passed

All tests on macOS X M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Fix more tests.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on macOS Mac Catalina (10.15) ❌

Tests failed on Mac Catalina (10.15).

Failed tests are:

  • introspection

Pipeline on Agent
Fix more tests.

Please sign in to comment.