Bump to mono/linker/main@b888d67 Mono.Cecil 0.11.4 #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#6131 Changes: Unknown; can't find commit which matches 0.11.2. dotnet/android#6131 is currently failing to build due to a Mono.Cecil version mismatch: CSC : error CS1705: Assembly 'illink' with identity 'illink, Version=6.0.100.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' uses 'Mono.Cecil, Version=0.11.4.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e' which has a higher version than referenced assembly 'Mono.Cecil' with identity 'Mono.Cecil, Version=0.11.3.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e' We thus need to bump all use of Mono.Cecil 0.11.2 to 0.11.4. Unfortunately, at this point in time there's no way for xamarin/xamarin-android to explicitly control which Mono.Cecil NuGet package version is used by Java.Interop. Introduce a new `$(_XamarinAndroidCecilVersion)` MSBuild property which can be used to override the default Mono.Cecil package version of 0.11.4 (up from 0.11.2). The xamarin-android build can then set `$(_XamarinAndroidCecilVersion)` by using `Configuration.Override.props`.
jpobst
approved these changes
Jul 28, 2021
jpobst
pushed a commit
that referenced
this pull request
Sep 30, 2021
Context: dotnet/android#6131 Changes: Unknown; can't find commit which matches 0.11.2. dotnet/android#6131 is currently failing to build due to a Mono.Cecil version mismatch: CSC : error CS1705: Assembly 'illink' with identity 'illink, Version=6.0.100.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' uses 'Mono.Cecil, Version=0.11.4.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e' which has a higher version than referenced assembly 'Mono.Cecil' with identity 'Mono.Cecil, Version=0.11.3.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e' We thus need to bump all use of Mono.Cecil 0.11.2 to 0.11.4. Unfortunately, at this point in time there's no way for xamarin/xamarin-android to explicitly control which Mono.Cecil NuGet package version is used by Java.Interop. Introduce a new `$(_XamarinAndroidCecilVersion)` MSBuild property which can be used to override the default Mono.Cecil package version of 0.11.4 (up from 0.11.2). The xamarin-android build can then set `$(_XamarinAndroidCecilVersion)` by using `Configuration.Override.props`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#6131
Changes: Unknown; can't find commit which matches 0.11.2.
dotnet/android#6131 is currently failing to build due to a
Mono.Cecil version mismatch:
We thus need to bump all use of Mono.Cecil 0.11.2 to 0.11.4.
Unfortunately, at this point in time there's no way for
xamarin/xamarin-android to explicitly control which Mono.Cecil
NuGet package version is used by Java.Interop.
Introduce a new
$(_XamarinAndroidCecilVersion)MSBuild propertywhich can be used to override the default Mono.Cecil package version
of 0.11.4 (up from 0.11.2). The xamarin-android build can then
set
$(_XamarinAndroidCecilVersion)by usingConfiguration.Override.props.