Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/installer #6131

Merged
merged 5 commits into from
Jul 30, 2021
Merged

[main] Update dependencies from dotnet/installer #6131

merged 5 commits into from
Jul 30, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 27, 2021 •
edited
Loading

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.ILLink.Tasks: from 6.0.100-preview.6.21370.1 to 6.0.100-preview.6.21378.1 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21374.7 to 6.0.0-rc.1.21378.2 (parent: Microsoft.Dotnet.Sdk.Internal)

From https://github.com/dotnet/installer

  • Subscription: 6548876b-06a1-4ab6-a5a5-08d8ed868088
  • Build: 20210729.2
  • Date Produced: 7/29/2021 9:39 AM
  • Commit: 3b433901a1bb025b3acb3ca2f73fc7c43ffd98b6
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
0a92b4d 
…210727.8

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-rc.1.21376.3 -> To Version 6.0.100-rc.1.21377.8

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref
 From Version 6.0.100-preview.6.21370.1 -> To Version 6.0.100-preview.6.21376.2 (parent: Microsoft.Dotnet.Sdk.Internal
jonathanpeppers
jonathanpeppers reviewed Jul 27, 2021
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the build:

(CoreCompile target) -> 
  CSC : error CS1705: Assembly 'illink' with identity 'illink, Version=6.0.100.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' uses 'Mono.Cecil, Version=0.11.4.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e' which has a higher version than referenced assembly 'Mono.Cecil' with identity 'Mono.Cecil, Version=0.11.3.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e'

I don't immediately see Microsoft.Android.Sdk.ILLink.csproj pulling in a different version of Mono.Cecil?

@jonathanpeppers
Copy link
Member

The one brought in seems like it is coming through as a dependency of Microsoft.NET.ILLink:

image

dotnet-maestro bot and others added 2 commits July 27, 2021 22:02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
b9fa43a 
…210727.14

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-rc.1.21376.3 -> To Version 6.0.100-rc.1.21377.14

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref
 From Version 6.0.100-preview.6.21370.1 -> To Version 6.0.100-preview.6.21376.2 (parent: Microsoft.Dotnet.Sdk.Internal
@jonpryor
Bump to Mono.Cecil 0.11.4.
fcb9ea3 
Hopefully fixes a [build break][0]:

	CSC : error CS1705: Assembly 'illink' with identity 'illink, Version=6.0.100.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
	uses 'Mono.Cecil, Version=0.11.4.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e'
	which has a higher version than referenced assembly
	'Mono.Cecil' with identity 'Mono.Cecil, Version=0.11.3.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e'

Bump `$(MonoCecilVersion)` to compensate?

Note: an actual fix very likely requires a Java.Interop bump, as
Java.Interop references Cecil 0.11.3 (same as the error message)
while `$(MonoCecilVersion)` is 0.11.2 (not present in the error).

[0]: #6131 (review)
jonpryor added a commit to jonpryor/java.interop that referenced this pull request Jul 28, 2021
@jonpryor
Bump to mono/linker/main@b888d67 Mono.Cecil 0.11.4
5260199 
Context: dotnet/android#6131

Changes: Unknown; can't find commit which matches 0.11.2.

dotnet/android#6131 is currently failing to build due to a
Mono.Cecil version mismatch:

	CSC : error CS1705: Assembly 'illink' with identity 'illink, Version=6.0.100.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
	uses 'Mono.Cecil, Version=0.11.4.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e'
	which has a higher version than referenced assembly
	'Mono.Cecil' with identity 'Mono.Cecil, Version=0.11.3.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e'

We thus need to bump all use of Mono.Cecil 0.11.2 to 0.11.4.

Unfortunately, at this point in time there's no way for
xamarin/xamarin-android to explicitly control which Mono.Cecil
NuGet package version is used by Java.Interop.

Introduce a new `$(_XamarinAndroidCecilVersion)` MSBuild property
which can be used to override the default Mono.Cecil package version
of 0.11.4 (up from 0.11.2).  The xamarin-android build can then
set `$(_XamarinAndroidCecilVersion)` by using
`Configuration.Override.props`.
@jonpryor jonpryor mentioned this pull request Jul 28, 2021
Merged
jonpryor added a commit to dotnet/java-interop that referenced this pull request Jul 28, 2021
@jonpryor
Bump to mono/linker/main@b888d67 Mono.Cecil 0.11.4 (#861)
dd1ef45 
Context: dotnet/android#6131

Changes: Unknown; can't find commit which matches 0.11.2.

dotnet/android#6131 is currently failing to build due to a
Mono.Cecil version mismatch:

	CSC : error CS1705: Assembly 'illink' with identity 'illink, Version=6.0.100.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
	uses 'Mono.Cecil, Version=0.11.4.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e'
	which has a higher version than referenced assembly
	'Mono.Cecil' with identity 'Mono.Cecil, Version=0.11.3.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e'

We thus need to bump all use of Mono.Cecil 0.11.2 to 0.11.4.

Unfortunately, at this point in time there's no way for
xamarin/xamarin-android to explicitly control which Mono.Cecil
NuGet package version is used by Java.Interop.

Introduce a new `$(_XamarinAndroidCecilVersion)` MSBuild property
which can be used to override the default Mono.Cecil package version
of 0.11.4 (up from 0.11.2).  The xamarin-android build can then
set `$(_XamarinAndroidCecilVersion)` by using
`Configuration.Override.props`.
@jonpryor
Bump to xamarin/Java.Interop/main@dd1ef455
75451b9 
Context: #6131 (review)
Context: fcb9ea3

Changes: http://github.com/xamarin/Java.Interop/compare/4fb7c147f8c6eb9bf94d9bfb8305c7d2a7a9fb33...dd1ef455ee4fbfa7e17f34c51cbe2ef24459e2e6

  * dotnet/java-interop@dd1ef455: Bump to mono/linker/main@b888d67 Mono.Cecil 0.11.4 (#861)

Commit fcb9ea3 didn't fix the build breakage.

Bump to xamarin/Java.Interop/main@dd1ef455 and set
`$(_XamarinAndroidCecilVersion)`, which will override the Mono.Cecil
NuGet package version within the Java.Interop build.

This will hopefully ensure/allow everything to now use Cecil 0.11.4.

TODO: This Quick-And-Dirty approach hardcodes
`$(_XamarinAndroidCecilVersion)`=0.11.4, meaning we now have two
different properties for the same thing:

	Directory.Build.props:    <MonoCecilVersion>0.11.4</MonoCecilVersion>
	build-tools/scripts/Configuration.Java.Interop.Override.props:    <_XamarinAndroidCecilVersion>0.11.4</_XamarinAndroidCecilVersion>

This is "undesirable".  Is there a way to update `xaprepare` so that
we can generate `external/Java.Interop/Configuration.Override.props`
so that `$(_XamarinAndroidCecilVersion)`=`$(MonoCecilVersion)`?

(Assuming that this approach even works…)
@jonpryor
Copy link
Member

Still not fixed. :-(

@jonathanpeppers
Copy link
Member

I think we should try a dotnet new classlib and add:

<!-- would also need NuGet.config with https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json -->
<PackageReference Include="Microsoft.NET.ILLink" Version="6.0.100-preview.6.21376.2" />

And see if that breaks or not.

@jonathanpeppers jonathanpeppers mentioned this pull request Jul 28, 2021
Closed
@jonathanpeppers
Copy link
Member

I filed: dotnet/linker#2178

It seems like it is a problem with this version of Microsoft.NET.ILLink, because I could reproduce in a small project.

@jonathanpeppers
Copy link
Member

Ok, should be fixed by: dotnet/linker#2174

@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
d78960c 
…210729.2

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-rc.1.21376.3 -> To Version 6.0.100-rc.1.21379.2

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref
 From Version 6.0.100-preview.6.21370.1 -> To Version 6.0.100-preview.6.21378.1 (parent: Microsoft.Dotnet.Sdk.Internal
@jonathanpeppers
Copy link
Member

jonathanpeppers commented Jul 29, 2021 •
edited
Loading

The new diff has the mono/linker fix: dotnet/linker@6eae019...0cb9250

jonathanpeppers
jonathanpeppers approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one test failure is legacy, and looked like Mono MSBuild crashed:

msbuild /Users/runner/work/1/s/bin/TestRelease/temp/MissingOrgApacheHttpClientd8/UnnamedProject.csproj /t:Build,SignAndroidPackage /noconsolelogger "/flp1:LogFile=/Users/runner/work/1/s/bin/TestRelease/temp/MissingOrgApacheHttpClientd8/build.log;Encoding=UTF-8;Verbosity=diagnostic" /restore @"/Users/runner/work/1/s/bin/TestRelease/temp/MissingOrgApacheHttpClientd8/project.rsp"
Microsoft (R) Build Engine version 16.10.1 for Mono
Copyright (C) Microsoft Corporation. All rights reserved.

/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/msbuild/15.0/bin/MSBuild.dll /noconsolelogger /bl:/Users/runner/work/1/s/bin/TestRelease/temp/MissingOrgApacheHttpClientd8/msbuild.binlog /flp1:LogFile=/Users/runner/work/1/s/bin/TestRelease/temp/MissingOrgApacheHttpClientd8/build.log;Encoding=UTF-8;Verbosity=diagnostic /p:BuildingInsideVisualStudio=True /p:BuildingOutOfProcess=true /p:AndroidSdkDirectory=/Users/runner/Library/Android/sdk /p:AndroidNdkDirectory=/Users/runner/Library/Android/ndk /p:JavaSdkDirectory=/Users/runner/Library/Android/jdk-1.8 /restore /t:Build,SignAndroidPackage /Users/runner/work/1/s/bin/TestRelease/temp/MissingOrgApacheHttpClientd8/UnnamedProject.csproj

=================================================================
	Native Crash Reporting
=================================================================
Got a segv while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries 
used by your application.
=================================================================

=================================================================
	Native stacktrace:
=================================================================
	0x10b2666a9 - /Library/Frameworks/Mono.framework/Versions/6.12.0/bin/mono : mono_dump_native_crash_info
	0x10b1fe57e - /Library/Frameworks/Mono.framework/Versions/6.12.0/bin/mono : mono_handle_native_crash
	0x10b260826 - /Library/Frameworks/Mono.framework/Versions/6.12.0/bin/mono : altstack_handle_and_restore
	0x7fff6cb7c8aa - /usr/lib/system/libsystem_platform.dylib : _platform_memmove$VARIANT$Nehalem
	0x10b313a6c - /Library/Frameworks/Mono.framework/Versions/6.12.0/bin/mono : ves_icall_System_Buffer_MemcpyInternal
	0x10cae5cd8 - Unknown
	0x10da4e90c - /Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/4.5/mscorlib.dll.dylib : System_IO_UnmanagedMemoryStream_Write_byte___int_int

=================================================================
	Telemetry Dumper:
=================================================================
Pkilling 0x123145524789248x from 0x123145518460928x
Pkilling 0x123145503694848x from 0x123145518460928x
Pkilling 0x123145522679808x from 0x123145518460928x
Pkilling 0x123145501585408x from 0x123145518460928x
Pkilling 0x123145520570368x from 0x123145518460928x
Pkilling 0x123145499475968x from 0x123145518460928x
Pkilling 0x123145497092096x from 0x123145518460928x
Pkilling 0x4519443904x from 0x123145518460928x
Pkilling 0x123145497366528x from 0x123145518460928x
Pkilling 0x123145494982656x from 0x123145518460928x
Pkilling 0x123145516351488x from 0x123145518460928x
Pkilling 0x123145489690624x from 0x123145518460928x
Pkilling 0x123145492873216x from 0x123145518460928x
Pkilling 0x123145514242048x from 0x123145518460928x
Pkilling 0x123145512132608x from 0x123145518460928x
Pkilling 0x123145510023168x from 0x123145518460928x
Pkilling 0x123145507913728x from 0x123145518460928x
Pkilling 0x123145505804288x from 0x123145518460928x
Entering thread summarizer pause from 0x123145518460928x
Finished thread summarizer pause from 0x123145518460928x.
Failed to create breadcrumb file (null)/crash_hash_0x34f90ca87d

Waiting for dumping threads to resume

=================================================================
	External Debugger Dump:
=================================================================

=================================================================
	Basic Fault Address Reporting
=================================================================
Memory around native instruction pointer (0x7fff6cb7c8aa):0x7fff6cb7c89a  f0 48 89 f9 48 29 c1 48 01 ce 48 29 ca 0f 10 0e  .H..H).H..H)....
0x7fff6cb7c8aa  0f 11 00 0f 10 56 10 0f 10 5e 20 0f 10 66 30 48  .....V...^ ..f0H
0x7fff6cb7c8ba  83 c6 40 48 81 ea 80 00 00 00 76 6a 48 f7 c6 0f  [email protected]...
0x7fff6cb7c8ca  00 00 00 74 31 0f 29 0f 0f 29 57 10 0f 29 5f 20  ...t1.)..)W..)_ 

=================================================================
	Managed Stacktrace:
=================================================================
	  at <unknown> <0xffffffff>
	  at System.Buffer:InternalMemcpy <0x00087>
	  at System.Buffer:Memcpy <0x00042>
	  at System.IO.UnmanagedMemoryStream:WriteCore <0x00181>
	  at System.IO.UnmanagedMemoryStream:Write <0x0016b>
	  at System.IO.Stream:CopyTo <0x000a8>
	  at System.IO.Stream:CopyTo <0x0003f>
	  at System.IO.Stream:CopyTo <0x000aa>
	  at NuGet.Packaging.StreamExtensions:CopyToFile <0x0039a>
	  at NuGet.Packaging.PackageFileExtractor:ExtractPackageFile <0x003ca>
	  at NuGet.Packaging.PackageArchiveReader:CopyFiles <0x00347>
	  at NuGet.Packaging.PackageReaderBase:CopyFilesAsync <0x00067>
	  at <<InstallFromSourceAsync>b__0>d:MoveNext <0x01057>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:Start <0x000fa>
	  at <>c__DisplayClass5_0:<InstallFromSourceAsync>b__0 <0x000ea>
	  at <ExecuteWithFileLockedAsync>d__4`1:MoveNext <0x00c6b>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:Start <0x000fa>
	  at NuGet.Common.ConcurrencyUtilities:ExecuteWithFileLockedAsync <0x0011a>
	  at <InstallFromSourceAsync>d__5:MoveNext <0x008f2>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:Start <0x000fa>
	  at NuGet.Packaging.PackageExtractor:InstallFromSourceAsync <0x001b2>
	  at <InstallPackageAsync>d__16:MoveNext <0x00572>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:Start <0x000fa>
	  at NuGet.Commands.ProjectRestoreCommand:InstallPackageAsync <0x00172>
	  at <<InstallPackagesAsync>b__4>d:MoveNext <0x000ca>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:Start <0x000f2>
	  at <>c__DisplayClass15_1:<InstallPackagesAsync>b__4 <0x000ca>
	  at SelectIPartitionIterator`2:MoveNext <0x000ee>
	  at System.Threading.Tasks.Task:WhenAll <0x004b9>
	  at <InstallPackagesAsync>d__15:MoveNext <0x00a42>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:Start <0x000fa>
	  at NuGet.Commands.ProjectRestoreCommand:InstallPackagesAsync <0x0019a>
	  at <TryRestoreAsync>d__9:MoveNext <0x00efa>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at WhenAllPromise`1:Invoke <0x00315>
	  at System.Threading.Tasks.Task:FinishContinuations <0x001fe>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <WalkDependenciesAsync>d__13:MoveNext <0x0073a>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <WalkAsync>d__2:MoveNext <0x00a92>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <CreateGraphNode>d__3:MoveNext <0x01aea>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task:FinishStageTwo <0x0018f>
	  at System.Threading.Tasks.Task:Finish <0x00091>
	  at System.Threading.Tasks.Task:ExecuteWithThreadLocal <0x00119>
	  at System.Threading.Tasks.Task:ExecuteEntry <0x000e8>
	  at System.Threading.Tasks.ThreadPoolTaskScheduler:TryExecuteTaskInline <0x00061>
	  at System.Threading.Tasks.TaskScheduler:TryRunInline <0x000fc>
	  at System.Threading.Tasks.TaskContinuation:InlineIfPossibleOrElseQueue <0x0007e>
	  at System.Threading.Tasks.StandardTaskContinuation:Run <0x00110>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00289>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at CompleteOnInvokePromise:Invoke <0x00040>
	  at System.Threading.Tasks.Task:FinishContinuations <0x001fe>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <CreateGraphNode>d__3:MoveNext <0x01aea>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task:FinishStageTwo <0x0018f>
	  at System.Threading.Tasks.Task:Finish <0x00091>
	  at System.Threading.Tasks.Task:ExecuteWithThreadLocal <0x00119>
	  at System.Threading.Tasks.Task:ExecuteEntry <0x000e8>
	  at System.Threading.Tasks.ThreadPoolTaskScheduler:TryExecuteTaskInline <0x00061>
	  at System.Threading.Tasks.TaskScheduler:TryRunInline <0x000fc>
	  at System.Threading.Tasks.TaskContinuation:InlineIfPossibleOrElseQueue <0x0007e>
	  at System.Threading.Tasks.StandardTaskContinuation:Run <0x00110>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00289>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at CompleteOnInvokePromise:Invoke <0x00040>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00613>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <CreateGraphNode>d__3:MoveNext <0x01aea>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task:FinishStageTwo <0x0018f>
	  at System.Threading.Tasks.Task:Finish <0x00091>
	  at System.Threading.Tasks.Task:ExecuteWithThreadLocal <0x00119>
	  at System.Threading.Tasks.Task:ExecuteEntry <0x000e8>
	  at System.Threading.Tasks.ThreadPoolTaskScheduler:TryExecuteTaskInline <0x00061>
	  at System.Threading.Tasks.TaskScheduler:TryRunInline <0x000fc>
	  at System.Threading.Tasks.TaskContinuation:InlineIfPossibleOrElseQueue <0x0007e>
	  at System.Threading.Tasks.StandardTaskContinuation:Run <0x00110>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00289>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at CompleteOnInvokePromise:Invoke <0x00040>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00613>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <CreateGraphNode>d__3:MoveNext <0x01aea>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <FindLibraryEntryAsync>d__1:MoveNext <0x00caa>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <CreateGraphItemAsync>d__2:MoveNext <0x0049a>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <GetDependenciesAsync>d__21:MoveNext <0x00802>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <<GetDependenciesAsync>b__0>d:MoveNext <0x0026a>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <GetDependenciesCoreAsync>d__22:MoveNext <0x00f3a>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <GetDependencyInfoAsync>d__9:MoveNext <0x00932>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <GetNuspecReaderFromNupkgAsync>d__6:MoveNext <0x00862>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e2>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x00112>
	  at <ProcessNupkgStreamAsync>d__8:MoveNext <0x00cda>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <ProcessStreamAndGetCacheEntryAsync>d__9:MoveNext <0x003a2>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <ProcessHttpSourceResultAsync>d__10`1:MoveNext <0x0153a>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <GetAsync>d__15`1:MoveNext <0x005f2>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <ExecuteWithFileLockedAsync>d__4`1:MoveNext <0x015d2>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000e5>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x000d2>
	  at <<GetAsync>b__0>d:MoveNext <0x025f2>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000ea>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x00122>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x0008a>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder:SetResult <0x0002e>
	  at <CreateCacheFileAsync>d__2:MoveNext <0x00a8a>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000ea>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x00122>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetResult <0x0008a>
	  at System.Runtime.CompilerServices.AsyncTaskMethodBuilder:SetResult <0x0002e>
	  at <CopyToAsyncInternal>d__28:MoveNext <0x00b2e>
	  at MoveNextRunner:InvokeMoveNext <0x000b0>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:Run <0x00042>
	  at MoveNextRunner:Run <0x000b9>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction <0x0007a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x00132>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x000ea>
	  at FromAsyncTrimPromise`1:Complete <0x000b2>
	  at FromAsyncTrimPromise`1:CompleteFromAsyncResult <0x00102>
	  at ReadWriteTask:InvokeAsyncCallback <0x0006f>
	  at System.Threading.ExecutionContext:RunInternal <0x001a9>
	  at System.Threading.ExecutionContext:RunInternal <0x0003a>
	  at ReadWriteTask:System.Threading.Tasks.ITaskCompletionAction.Invoke <0x000d9>
	  at System.Threading.Tasks.Task:FinishContinuations <0x001fe>
	  at System.Threading.Tasks.Task:FinishStageThree <0x00080>
	  at System.Threading.Tasks.Task:FinishStageTwo <0x0018f>
	  at System.Threading.Tasks.Task:Finish <0x00091>
	  at System.Threading.Tasks.Task:ExecuteWithThreadLocal <0x00119>
	  at System.Threading.Tasks.Task:ExecuteEntry <0x000e8>
	  at System.Threading.Tasks.Task:System.Threading.IThreadPoolWorkItem.ExecuteWorkItem <0x00026>
	  at System.Threading.ThreadPoolWorkQueue:Dispatch <0x00279>
	  at System.Threading._ThreadPoolWaitCallback:PerformWaitCallback <0x0001c>
	  at <Module>:runtime_invoke_bool <0x000a5>
=================================================================
ExitCode: 134

We can keep an eye on this if it becomes common.

@jonathanpeppers jonathanpeppers merged commit d2a31d1 into main Jul 30, 2021
@jonathanpeppers jonathanpeppers deleted the darc-main-193b8d0d-0d10-477c-b842-fb7a72521a81 branch July 30, 2021 13:09
jpobst pushed a commit to dotnet/java-interop that referenced this pull request Sep 30, 2021
@jonpryor @jpobst
Bump to mono/linker/main@b888d67 Mono.Cecil 0.11.4 (#861)
60aa87f 
Context: dotnet/android#6131

Changes: Unknown; can't find commit which matches 0.11.2.

dotnet/android#6131 is currently failing to build due to a
Mono.Cecil version mismatch:

	CSC : error CS1705: Assembly 'illink' with identity 'illink, Version=6.0.100.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
	uses 'Mono.Cecil, Version=0.11.4.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e'
	which has a higher version than referenced assembly
	'Mono.Cecil' with identity 'Mono.Cecil, Version=0.11.3.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e'

We thus need to bump all use of Mono.Cecil 0.11.2 to 0.11.4.

Unfortunately, at this point in time there's no way for
xamarin/xamarin-android to explicitly control which Mono.Cecil
NuGet package version is used by Java.Interop.

Introduce a new `$(_XamarinAndroidCecilVersion)` MSBuild property
which can be used to override the default Mono.Cecil package version
of 0.11.4 (up from 0.11.2).  The xamarin-android build can then
set `$(_XamarinAndroidCecilVersion)` by using
`Configuration.Override.props`.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@jonpryor jonpryor Awaiting requested review from jonpryor jonpryor is a code owner

@pjcollins pjcollins Awaiting requested review from pjcollins pjcollins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanpeppers @jonpryor