Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry to .sh script #130

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Add retry to .sh script #130

merged 2 commits into from
Feb 1, 2021

Conversation

bekir-ozturk
Copy link
Contributor

Delivers #95

@bekir-ozturk bekir-ozturk requested a review from AR-May January 27, 2021 11:34
AR-May
AR-May approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@AR-May AR-May left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have a proper retry functionality, we may also reconsider curl and wget options. They also have retry functionality themselves that works for connection and I wonder if we still need 20 retries with 2 sec of delay there.

@AR-May AR-May removed their assignment Jan 28, 2021
vlada-shubina
vlada-shubina reviewed Jan 28, 2021
View reviewed changes
Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the user should wait if wget/curl is not installed - I think exit immediately is a better way so the user can install the tool and try again.

src/dotnet-install.sh Outdated
elif machine_has "wget"; then
downloadwget "$remote_path" "$out_path" || failed=true
else
failed = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably we don't need to retry in this case

@bekir-ozturk bekir-ozturk merged commit e4f6983 into master Feb 1, 2021
@bekir-ozturk bekir-ozturk deleted the dev/bozturk/add-retry-to-sh branch February 1, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlada-shubina vlada-shubina vlada-shubina approved these changes

@AR-May AR-May AR-May approved these changes

Assignees

@vlada-shubina vlada-shubina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bekir-ozturk @vlada-shubina @AR-May