Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry logic to .sh script #95

Closed
bekir-ozturk opened this issue Nov 5, 2020 · 4 comments
Closed

Add retry logic to .sh script #95

bekir-ozturk opened this issue Nov 5, 2020 · 4 comments
Assignees
@bekir-ozturk
Labels
triaged

Comments

@bekir-ozturk
Copy link
Contributor

Sh script invokes curl with retry option. However, the retry logic is only working while attempting to connect to the given url and the script doesn't seem to be retrying if the connection is interrupted during the download.

Add retry logic to whole download operation so that we can recover from interrupted downloads.
@bekir-ozturk bekir-ozturk self-assigned this Nov 5, 2020
@bekir-ozturk
Copy link
Contributor Author

Downloading "product.version" files should also be using the same logic.

This was referenced Nov 5, 2020
Closed
Closed
@bekir-ozturk
Copy link
Contributor Author

We have decided to cut this in favor of no longer delaying the maintenance mode since it doesn't promise a great impact on the incidents.

@bekir-ozturk
Copy link
Contributor Author

We decided to implement this in order to improve the resiliency against the issues discussed in #127.

@bekir-ozturk bekir-ozturk reopened this Jan 27, 2021
This was referenced Jan 27, 2021
Merged
Closed
@bekir-ozturk
Copy link
Contributor Author

The fix was merged and the changes will be available on dot.net soon. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bekir-ozturk bekir-ozturk

Labels
triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bekir-ozturk