-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to disable in-memory cross-project references #3328
Conversation
It would be great if you describe what this setting changes exactly, I mean what features degrade if it turned on. |
@vasily-kirichenko Yes, will do. The change is part of an investigation for a problem with a particular user, it's not for immediate pull |
@vasily-kirichenko Here are my notes from an internal email. Thanks for reminding me to be transparent ... a scenario of excessive memory usage in a large solution is described via private screenshots ... My response below, slightly edited I believe there are several things potentially going on here:
In-memory cross-project references can also use significantly more memory. People who had the Visual F# Power Tools installed in VS2015 would experience overall less memory usage, because VFPT in VS2015 used a duplicate copy of the language service state with cross-project references enabled. However in the scenario described, the Visual F# Power Tools are not enabled.
So I believe (2) is the primary cause of the behaviour in the scenario. Essentially we are paying the cost for eliminating the manual builds of project references – i.e. doing things “right” but much more slowly in large solutions. Tactically, I believe the two things would be
To this:
If we verify that disabling this solves the problem, I would recommend that the
I will prepare a PR which the customer can pull or we can pull into master
Two other cards to play I can think of are:
|
this is ready |
@vasily-kirichenko I'm not sure if you're in the mood but you might be interested in these if they are helpful to you as a user:
|
With in-memory cross-project references enabled or disabled? |
I think this is #3047 |
Disabled. |
Closing in favour of #3330 |
No description provided.