Cancel background work #3063
Cancel background work #3063
Conversation
src/fsharp/vs/Reactor.fs
Outdated
| Trace.TraceInformation("Reactor: --> wait for background {0}.{1} ({2}), remaining {3}", bgUserOpName, bgOpName, bgOpArg, inbox.CurrentQueueLength) | ||
| while bgOp ctok do | ||
| Trace.TraceInformation("FCS: --> wait for background {0}.{1} ({2}), remaining {3}", bgUserOpName, bgOpName, bgOpArg, inbox.CurrentQueueLength) | ||
| bgOpCts <- new CancellationTokenSource() |
There was a problem hiding this comment.
Shouldn't we dispose the old bgOpCts first?
src/fsharp/vs/Reactor.fs
Outdated
| let time = Stopwatch() | ||
| time.Start() | ||
| let res = bgOp ctok | ||
| bgOpCts <- new CancellationTokenSource() |
| @@ -10,7 +10,7 @@ open OptionsUIHelpers | |||
|
|
|||
| module DefaultTuning = | |||
| let SemanticColorizationInitialDelay = 0 (* milliseconds *) | |||
| let UnusedDeclarationsAnalyzerInitialDelay = 1000 (* milliseconds *) | |||
| let UnusedDeclarationsAnalyzerInitialDelay = 0 (* milliseconds *) | |||
There was a problem hiding this comment.
Yes I think this is ok.
|
A quick update on this: I've been trying to use this in practice to get a sense if the cancellation makes for a better overall experience - for example I'm vaguely concerned there might be situations where the background builder never really makes progress because so many requests are coming in to FCS from things like the "SimplifyName" code fix. I'll keep using it myself and keep an eye on things. |
|
This is now ready |
|
For the record, @KevinRansom asked me why I was originally hesitant about this PR. My reply:
|
This is a WIP PR to extend #3061.
In #3061 I noticed that therre we some long running, non-cancellable operations on the background thread. This means, for example, that if you
then there will be no intellisense or colorization in the script until the basic preparation of project P (and possibly the complete checking of its dependencies) is finished
This PR cancels background work when new foreground work arrives that will implicitly start replacement background work (e.g. to prepare a script).