Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidating code around process exiting #13784

Merged
merged 24 commits into from
Sep 17, 2022
Merged

Consolidating code around process exiting #13784

merged 24 commits into from
Sep 17, 2022

Conversation

psfinaki
Copy link
Member

@psfinaki psfinaki commented Aug 25, 2022

closes #13748

So apparently we already have the right thing in the codebase so just plugging it in in a couple places.
QuitProcessExiter is here.

@psfinaki psfinaki requested a review from vzarytovskii August 25, 2022 12:00
@psfinaki psfinaki enabled auto-merge (squash) August 25, 2022 12:02
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider parameterizing the process exiter.

Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Thank you

@psfinaki
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki psfinaki merged commit db38206 into main Sep 17, 2022
@psfinaki psfinaki deleted the psfinaki/13748-2 branch November 7, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use proper process exiting mechanism in FSC
5 participants