Refactoring langversion options in FSC #13785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0101
reviewed
Aug 29, 2022
0101
approved these changes
Aug 29, 2022
KevinRansom
requested changes
Sep 2, 2022
| None, | ||
| Some(FSComp.SR.optsGetLangVersions ()) | ||
| ) | ||
|
|
||
| CompilerOption( |
There was a problem hiding this comment.
So the original goal was to match the semantics implemented by the C# compilers lang version switch:
as you can see -langversion is invalid and --langversion:? returns the list
It may not be the end of the world to make the change, but in general we try to keep things similarly between the products when both implement them.
psfinaki
force-pushed
the
psfinaki/13749
branch
2 times, most recently
from
da99b91 to
0c172c9
Compare
psfinaki
force-pushed
the
psfinaki/13749
branch
from
0c172c9 to
f6b8031
Compare
|
Closing in favor of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13749
Splitting the all-in-one flag into two clear options, similar to how we have it with some other things like
targetordebug.