Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feature/auto-widen to feature/erased-unions #11823

Conversation

dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from feature/auto-widen into feature/erased-unions.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout merges/feature/auto-widen-to-feature/erased-unions
git reset --hard upstream/feature/erased-unions
git merge upstream/feature/auto-widen
# Fix merge conflicts
git commit
git push upstream merges/feature/auto-widen-to-feature/erased-unions --force

Don Syme and others added 14 commits July 6, 2021 14:15
* Use RunImmediate for better debug stacks

* fix build

Co-authored-by: Don Syme <[email protected]>
…pe providers (#11791)

* fix regression for projects referencing projects using generative type providers

* add test

* remove test projects which are too ahrd to compile

* add testing

* enable for .NET core too

* fix build

Co-authored-by: Don Syme <[email protected]>
…cals and debug points intra-assembly (#11717)" (#11792)

This reverts commit 9cbbf4c.
* fix 11797

* fix 11797

* fix 11797

Co-authored-by: Don Syme <[email protected]>
* RunImmediate uses RunSynchronously on UI thread

Co-authored-by: Don Syme <[email protected]>
…ved. (#11781)

* Correct body SynExpr of parsedData of Lambda when wildcards are involved.

* Update ProjectAnalysisTest.

* update baselines

Co-authored-by: Don Syme <[email protected]>
* fix 11797

* cleanup async.fs

* add benchmarks

* revert addition of extra hijack check on Bind for performance reasons

* include low allocation implementations that run slower with #if

* re-enable test fragment

* clean up and document code
* Warn unsupported attributes
@KevinRansom KevinRansom merged commit 7a635f3 into feature/erased-unions Jul 13, 2021
@dotnet-bot dotnet-bot deleted the merges/feature/auto-widen-to-feature/erased-unions branch July 13, 2021 21:03
@dotnet-bot dotnet-bot restored the merges/feature/auto-widen-to-feature/erased-unions branch July 13, 2021 22:17
@dotnet-bot dotnet-bot deleted the merges/feature/auto-widen-to-feature/erased-unions branch July 14, 2021 00:04
@dotnet-bot dotnet-bot restored the merges/feature/auto-widen-to-feature/erased-unions branch July 14, 2021 03:04
@dotnet-bot dotnet-bot deleted the merges/feature/auto-widen-to-feature/erased-unions branch July 14, 2021 06:04
@dotnet-bot dotnet-bot restored the merges/feature/auto-widen-to-feature/erased-unions branch July 14, 2021 09:04
@dotnet-bot dotnet-bot deleted the merges/feature/auto-widen-to-feature/erased-unions branch July 14, 2021 09:04
@dotnet-bot dotnet-bot restored the merges/feature/auto-widen-to-feature/erased-unions branch July 14, 2021 12:04
@dotnet-bot dotnet-bot deleted the merges/feature/auto-widen-to-feature/erased-unions branch July 14, 2021 15:04
@dotnet-bot dotnet-bot restored the merges/feature/auto-widen-to-feature/erased-unions branch July 14, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants