Fix 11771 - cross-project references for projects using generative type providers #11791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
changed the title
added 2 commits
July 7, 2021 14:43
|
@TIHan this is ready, pending green |
|
OK, ready |
TIHan
reviewed
Jul 7, 2021
| @@ -2184,7 +2184,7 @@ type FSharpCheckProjectResults | |||
| keepAssemblyContents: bool, | |||
| diagnostics: FSharpDiagnostic[], | |||
| details:(TcGlobals * TcImports * CcuThunk * ModuleOrNamespaceType * Choice<IncrementalBuilder, TcSymbolUses> * | |||
| TopAttribs option * IRawFSharpAssemblyData option * ILAssemblyRef * | |||
| TopAttribs option * ILAssemblyRef * | |||
TIHan
reviewed
Jul 7, 2021
| return None | ||
| // Note 'false' - if a PEReference doesn't find an ILModuleReader then we don't | ||
| // continue to try to use an on-disk DLL | ||
| return ProjectAssemblyDataResult.Unavailable false |
There was a problem hiding this comment.
Ok, so this should behave the same as before. - We basically only do useOnDisk for type providers.
There was a problem hiding this comment.
Yes, though I suspect it's right for this path too - it's hard to imagine a situation where dropping the reference on the floor is better than reusing an on-disk DLL
TIHan
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes regression #11771
The regression was in the addition of these lines: https://github.com/dotnet/fsharp/pull/11485/files#diff-015b2a27e0e013656556b5d7e867b1f66a17e145606d4a9abea5eeadd8b7820cR1581
We had had this bug before, fixed here: Disable in-memory project references for projects using generative type providers #3236.
An explicit test was added for it however it was disabled three years ago or so and never got re-enabled https://github.com/dotnet/fsharp/blame/main/tests/service/MultiProjectAnalysisTests.fs#L905