Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds NUnit test tutorial for .NET Core Visual Basic #3859

Merged
merged 3 commits into from
Dec 5, 2017

Conversation

rprouse
Copy link
Contributor

@rprouse rprouse commented Dec 1, 2017

Summary

The Getting Started with Testing page for .NET Core has tutorials for xUnit and MSTest. This adds documentation and a sample project for NUnit in Visual Basic. To keep the size of the PRs manageable, I have submitted C# and F# tutorials separately.

See #1785 - Document NUnit in .NET Core Guide > Unit Testing

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also really great content. Just a couple quick fixes, and then I'll merge it.

Thanks!

Change the directory back to the *unit-testing-vb-using-stest* directory. Run [`dotnet sln add .\PrimeService\PrimeService.vbproj`](../tools/dotnet-sln.md)
to add the class library project to the solution.

### Install the NUnit project template
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H2 instead of H3.


### Install the NUnit project template

The NUnit test project templates need to be installed before creating a test project. This only needs to be done once. Run [`dotnet new -i NUnit3.DotNetNew.Template`](../tools/dotnet-new.md) to install the NUnit templates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as the C# project: Let's clarify that this is a per machine install.

@rprouse
Copy link
Contributor Author

rprouse commented Dec 5, 2017

@BillWagner suggested changes to installing the project template have been made and this is ready for re-review.

@BillWagner
Copy link
Member

Thanks again @rprouse

These are a great addition. I'll :shipit: as soon as the build finishes.

Thanks again. 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants