Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document NUnit in .NET Core Guide > Unit Testing #1785

Closed
guardrex opened this issue Mar 22, 2017 · 18 comments
Closed

Document NUnit in .NET Core Guide > Unit Testing #1785

guardrex opened this issue Mar 22, 2017 · 18 comments

Comments

@guardrex
Copy link
Contributor

guardrex commented Mar 22, 2017

#@VitalyLitvinuk asks on Unit testing with MSTest and .NET Core ...

What about NUnit? Is there any guide how to create/setup project to use this framework? Have any plans about NUnit test project creation via "dotnet new nunit"?

A doc covering NUnit might be temporarily blocked by nunit/nunit3-vs-adapter#297, and commentary in nunit/nunit3-vs-adapter#308 indicates on-going work.

cc/ @rprouse

[EDIT] Note to self: Add to dotnet test topic.

@guardrex guardrex added Area - Conceptual Docs blocked Blocked for some reason labels Mar 22, 2017
@guardrex guardrex added this to the 2017 - Quarter 2 milestone Mar 22, 2017
@guardrex guardrex self-assigned this Mar 22, 2017
@rprouse
Copy link
Contributor

rprouse commented Mar 24, 2017

I am working on support in the NUnit adapter, although we don't have an issue yet to track adding templates. At the moment, the only way to run NUnit .NET Core tests that have been converted to CSPROJ is to convert them to NUnitLite self-executing tests, but that shouldn't be documented.

@guardrex guardrex added the help wanted Good for community contributors to help [up-for-grabs] label Mar 24, 2017
@guardrex
Copy link
Contributor Author

@rprouse Thanks. I'll keep an eye on progress. If this doc is approved later by management, someone will get right on it when you're ready and they pull the trigger.

@guardrex guardrex removed the help wanted Good for community contributors to help [up-for-grabs] label Mar 29, 2017
@mairaw mairaw added the P1 label Jun 19, 2017
@mairaw mairaw modified the milestones: 2017 - Quarter 3, 2017 - Quarter 2 Jun 19, 2017
@guardrex
Copy link
Contributor Author

Hello @rprouse ... can I ping you for a sec for an update on where things stand? It looks like according to nunit/nunit3-vs-adapter#297 that things aren't quite ready yet.

@rprouse
Copy link
Contributor

rprouse commented Jun 27, 2017

@guardrex there have been a few issues reported with the alpha release of the adapter, but nothing serious or consistently reproducible. We actually haven't released a second alpha yet because we haven't found anything serious enough to fix. I have a couple of smaller issues on my plate, so there will likely be an update soon.

If the docs are updated, they should probably use a * for the version, but other than that, everything is pretty much good to go. See http://www.alteridem.net/2017/05/04/test-net-core-nunit-vs2017/

@guardrex
Copy link
Contributor Author

Thanks @rprouse for the update.

@mairaw Do u want this after the current/upcoming workload assignments ("upcoming" == that you said you would be making soon), or do u want this one worked now?

@guardrex
Copy link
Contributor Author

@rprouse We're going to hold for just a sec while you get past alpha. I'll keep an 👁️ out. I'm tracking on issue nunit/nunit3-vs-adapter#297. If there's a better spot to monitor for beta landing, let me know, and I'll watch it.

@rprouse
Copy link
Contributor

rprouse commented Jun 29, 2017

@guardrex I guess I'd better get off my butt and release a beta then. The other place to track will be the https://github.com/nunit/nunit3-vs-adapter/releases, although you don't get notifications for those.

To be honest, except for the version, the documentation won't change. The code is very stable and I won't be changing much.

@guardrex
Copy link
Contributor Author

@rprouse Thanks for the link. I'll keep an eye on both.

I'd better get off my butt and release a beta then ... except for the version, the documentation won't change.

😀 It's more of a fear of changes 👻 than anything else. I think we just want to make sure we dedicate the time and don't get much churn between beta and release when that comes later. Alpha-TO-beta-TO-release ... that whole chain of possible changes is the scary part.

I can get to the outline and get that setup soon-ish. This week isn't looking good tho ... early next week perhaps ... but soon.

@guardrex
Copy link
Contributor Author

@mairaw Working this is going to post-date my tenure on the team, so I'm un-assigning it. Do u want to re-assign?

@guardrex guardrex removed their assignment Jul 21, 2017
@rprouse
Copy link
Contributor

rprouse commented Jul 24, 2017

@guardrex we have released the 3.8 version of the NUnit adapter. It is no longer pre-release.

@guardrex
Copy link
Contributor Author

@rprouse 🎉 🎈 🍻 Excellent news! This work will post-date my tenure with the docs team, hence my un-assignment. The least I can do tho is get it off of "blocked" status. This is a priority issue, so they'll get someone on it asap. Thanks for letting us know! ... and congrats on the latest release! The community speaks very highly of NUnit.

@guardrex guardrex removed the blocked Blocked for some reason label Jul 24, 2017
@mairaw mairaw removed the 0 - Backlog label Aug 1, 2017
@mairaw mairaw modified the milestones: Backlog, 2017 - Quarter 3 Sep 5, 2017
@BillWagner
Copy link
Member

@KathleenDollard Where in the backlog for the CLI is support for dotnet new NUnit? We'll move this issue to the milestone that matches that addition.

@rprouse
Copy link
Contributor

rprouse commented Sep 14, 2017

@KathleenDollard or @BillWagner is there an issue tracking dotnet new nunit? Can we help out?

@mairaw
Copy link
Contributor

mairaw commented Sep 15, 2017

Tagging some other folks to see if we have an issue tracking dotnet new nunit

/cc @livarcocc @mlorbetske @sayedihashimi

@sayedihashimi
Copy link
Member

dotnet new has support for installing templates from NuGet. In this case I would think that the NUnit team should author and own their own template.

@rprouse
Copy link
Contributor

rprouse commented Dec 1, 2017

I am working on these docs. I will submit separate PRs for each language.

@rprouse
Copy link
Contributor

rprouse commented Dec 5, 2017

@BillWagner you should be able to close this issue once my three PRs are merged.

@BillWagner
Copy link
Member

Closed in a combination of #3856 #3858 and #3859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants